Download & Extend

[meta] Shortlist of issues for a new release + find needed patches until then

Project:Comment notify
Version:7.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

It's time for a 7.x-1.0 release. Let's decide which issues should get fixed before then. Please keep the list short and actionable - critical issues should be included AND issues with a patch or a clear path to complete.

This list has two purposes:
1 - Make it easier for site builders to find the patches they need to apply (they should test the patch and report back about whether the patch works)
2 - As a help for the maintainers to quickly locate the existing patches/bugs and apply the to a new dev version or alpha/beta/RC/release.

Issues to fix before a 7.x-1.0 release:
#639618: user warning: Field 'notified' doesn't have a default value
#1008938: New users do not get default state settings - was fixed by #1234818: comment notifications turned off for new users by default: variable misnamed

Issues that need work or might not make it in:
#288726: Allow users to subscribe without posting a comment
#1221870: Javascript attachment problem when comment form is rendered via Panels

Comments

#1

Thanks for collecting these. I agree it will be great to create a new release.

I've started committing them.

It would be great if, in addition to listing them, you could test out the patches that exist and provide reviews of the patches.

Also, while I like the idea in "allow users to subscribe without posting a comment" I think it needs some real thought before doing.

#2

Brilliant @greggles. Yes, I will download the latest dev and start testing the patches for the remaining open issues.

In particular I am very interested to help get the #1008938: New users do not get default state settings issue fixed, but the other are very important too. Until now I have used a heavily patched version that fixes pretty much everything besides that and the subscribe without comment feature.

Glad to see progress is being made on this. Great work.

#3

I updated the initial issue (yay issue summaries) a bit to state the current status and list of issues that, imo, we should really get done.

#4

IMHO #1008938: New users do not get default state settings should be fixed as well, after all there is an admin setting for it and it wasn't until I discovered by accident it didn't work and filed the issue.

#1176546: Make user profile setting available in Manage Fields Seems to be quite easy to fix for someone that know a little bit of Drupal coding (which is not really me). I've added some reference info to a similar issue I filed for XML sitemap to it (hint: was fixed and committed in less than 3h after issue was filed).

Since this is a setting that most likely will be available on every users edit page, not being able to organize it under the Manage Fields/Display makes it virtually impossible to create good looking edit pages for users without custom coding.

#5

Updated issue summary and removed closed and fixed issues. Only 2+2 left now, yay.

#6

Status:active» fixed

Marking this fixed. The remaining two issues need more work and do not feel, to me, like they are critically central to the function of this module.

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#8

Status:closed (fixed)» active

Maybe I was a little optimistic on that...

#1284142: Unchecking the 'Notify me when new comments are posted' box on a comment doesn't save still needs to be fixed.

Any others?

#9

Status:active» closed (fixed)

Nope, guess not.