A suggestion is to change the option key for "None" for "Collapsible forum containers" from 'none' to ''.

Why?

The if case bellow will never be false, so toogle icon will always be showed.

// advanced_forum.naked.forum-list.tpl.php
// $collapsible can have the value: 'none', 'fade', 'slide' and 'toggle'.
  if ($collapsible):

To not have to make if ($collapsible != 'none'): you can make these changes bellow.

// advanced_forum_preprocess_forum_list.inc:15
  if ($variables['collapsible'] != 'none') {
//to
  if ($variables['collapsible']) {

// settings.inc:110
  'none' => t("None"),
//to
  '' => t("None"),

If you make those changes, the toogle icon will be hidden when "None" is choosen as effect and it will not have any impact on the javascript.

Comments

mcdruid’s picture

mcdruid commented
Status: Active » Closed (fixed)

Thanks Scyther.

I didn't do this by changing the key to '' although that would have worked.

I think it's cleaner to set

$collapsible = FALSE;

...in the preprocess function if the 'none' option has been selected.

The D7 branch does something very similar.

Committed to 6.x-2.x branch.

mcdruid’s picture

mcdruid commented
Status: Closed (fixed) » Fixed

oops - realised I should have been setting issues to "fixed" rather than "closed (fixed)"

Scyther’s picture

Scyther commented

Maybe the value of 'None' should also be changed to '- None -' to follow Taxonomy (taxonomy.module:438), CCK (optionwidgets.module:429) and other modules.

What do you think about that mcdruid?

Scyther’s picture

Scyther commented
Status: Fixed » Active
mcdruid’s picture

mcdruid commented
Status: Active » Fixed

Thanks; changed to '- None -' and committed to 6.x-2.x branch (eventually).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.