Attached is a patch to optimize the select queries in Site verifcation to use the slave database when configured and available. Could this be incorporated? Thanks!

CommentFileSizeAuthor
#3 opt-queries-1193912-3.patch644 bytesamanaplan
opt-queries.patch2.81 KBamanaplan

Comments

amanaplan’s picture

amanaplan commented
Status: Active » Needs review
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Core doesn't seem to establish a pattern of using slave servers when using queries in validation or load hooks, so I'm very hesitant to approve those changes.

amanaplan’s picture

amanaplan commented
StatusFileSize
new opt-queries-1193912-3.patch644 bytes

Definitely understood and a valid hesitation. What do you think about just using slave servers to query the verification meta tags to add to the front page? It may seem pretty insignificant, but I'm trying to reduce overall master database load on the front page for logged in users (where a lot of activity is occurring and Varnish, of course, is not an option). Many thanks for your time.

joachim’s picture

joachim commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)

This seems to me to definitely be something that should be handled at the core level -- the connection object has the ability to have default options for all queries: https://api.drupal.org/api/drupal/includes!database!database.inc/functio.... I imagine those can be set somehow. If not, then that's a core bug. It shouldn't be necessary to patch all contrib modules in this way!