User saving location was broken: this is a fix...

Having done the above fix, I discovered a related problem: new users have an entry made for them in the location table, but the location values do no exist yet - so it enters 0 for both. This means when the new user goes to set their location via their accounts page, they initially find themselves just south of Africa!

Anyway, here's a fix. I imagine it doesn't really fit into the overall gmap.location methods, but it works. Note: I've hard-wired my default location values in, but I guess there's a way to access the default values set in the gmap.location settings page. (I don't need to do this, so didn't bother, sorry!)

Anyway, in gmap_location.module from line 622. It checks to see if user->id exists in the table and, if so, whether latitude is null or zero. If so, we presume its a new user and set the default values into {location} rather than use the $edit array.

//Get the last lid - which is the primary key in the location table - 
	//and inc by one for the next row.
	      
	$query = db_query("SELECT MAX(lid) FROM {location}");

	$lid = db_result($query);
		
	$lid++;
	
	//Need to check:
	//1. Does the user->uid exist in the location table yet? If not (e.g. latitude = null or zero) use default values.
	//2. Does the $user->uid in the table have a lat value of 0 or NULL? If not, default
	
	$setlatlongdefault = false;
	
	$query = db_query("SELECT eid, latitude FROM {location} WHERE eid=%d", $user->id);
	
	//Did we get a result? If not, they're in the table...
	
	$field = db_result($query);
	
	if (is_null($field->latitude) || $field->latitude ==0) {$setlatlongdefault = true;}
	
		
		if ($setlatlongdefault) {
			
			db_query("INSERT INTO {location} (eid, lid, type, latitude, longitude, source) VALUES (%d, %d, 'user', %s, %s, 1)",
			$user->uid,
			$lid,
			54.5,
			-3.5);}
					
			else {
	
			db_query("INSERT INTO {location} (eid, lid, type, latitude, longitude, source) VALUES (%d, %d, 'user', %s, %s, 1)",
			$user->uid,
			$lid,
			gmap_decimal($edit['gmap_location_latitude']),
			gmap_decimal($edit['gmap_location_longitude']));
		      
			} //end of else 664

Hia,

First, I have to say my patch is, er, patchy! There may well be a much simpler fix for the problem elsewhere in the code, and I'm not at all sure why you're install shouldn't have created the lid column - sorry. I'm also new to this module, and just trying to get it to work.

I've also discovered some whole new problems: when an admin creates a new account, a {location} entry is made for the user. When a user creates their own account, it isn't. This means that my previous test for setting default location values wasn't working. Here's a fix again - it checks the user table to see if the user has accessed their account. If they haven't, admin made it (and so values already exist for location.) If they have, when they access their location setter, they don't want the values set to default, but the one they select.

I'm hoping someone who knows about this project is going to come along and say why this is a complicated solution, and that there's something much simpler...! But needs must, and this has worked for me. (Sorry I can't help with the missing column conundrum...)

Remember, those are my default lat and long values... I haven't taken them from Gmap's own. From line 622 of gmap_location again:

<?php

$query = db_query("SELECT MAX(lid) FROM {location}");

	$lid = db_result($query);
		
	$lid++;
	
	//Need to check:
	//1. Does the user->uid exist in the location table yet? (e.g. latitude = null or zero) If not, then:
	//Has the user accessed their account? If not, then  use default values.
	
	$setlatlongdefault = false;
	
	$query = db_query("SELECT latitude FROM {location} WHERE eid=%d", $user->uid);
		
	$field = db_result($query);
	
	$querytwo = db_query("SELECT access FROM {users} WHERE uid=%d", $user->uid);

	$fieldtwo = db_result($querytwo);
	
	if ((is_null($field) || $field ==0) && (is_null($fieldtwo))||$fieldtwo==0 ) {$setlatlongdefault = true;} 
	
		if ($setlatlongdefault) {
			
			db_query("INSERT INTO {location} (eid, lid, type, latitude, longitude, source) VALUES (%d, %d, 'user', %s, %s, 1)",
			$user->uid,
			$lid,
			54.5,
			-3.5);}
					
			else {
	
			db_query("INSERT INTO {location} (eid, lid, type, latitude, longitude, source) VALUES (%d, %d, 'user', %s, %s, 1)",
			$user->uid,
			$lid,
			gmap_decimal($edit['gmap_location_latitude']),
			gmap_decimal($edit['gmap_location_longitude']));
	?>

Just thought I'd add: I'm not sure anyone should be using these patches until we hear back from someone more experienced with this project. They've worked for me - but then I also keep on finding new problems as a result of my attempted fixes! The last one does now seem to be working, but some other problems might turn up...

Ah! I think I can explain this one, sorry, should have said:

1. You have to put the tags around code when pasting to the forum, otherwise it won't make it nice and pretty coloured - but you should leave them out of the pasting in.

2. And, just to make things even more odd, drupal modules don't use both PHP tags. You're supposed to open with <?php - but not close it again at the end of the code.

Hope that might help. I also hope you haven't spent five hours trying to work this out. Ah, the joys of the open source community...

Jedit is a nice, light editor that has PHP highlighting: I've enjoed using it lots.

http://www.jedit.org/

(You need to turn on the PHP parser in the plug-ins...)