Forum messages from hell [#11940]

Comment #1

kps commented 11 November 2004 at 23:47

Component:

forum.module

» node.module

The attached patch sends the user to the front page instead of the newly created node, if they don't have permission to view it.

Log in or register to post comments

Comment #2

kps commented 11 November 2004 at 23:50

Lovely. Drupal.org doesn't have an upload directory right now, so it lets me attach a file, then... throws it away. Oh well, that's for another bug report.

--- node.module	Sat Oct 23 12:47:20 2004
+++ node.module	Thu Nov 11 18:43:20 2004
@@ -1377,7 +1377,12 @@ function node_submit($node) {
 
   // Node was submitted successfully. Redirect to the viewing page.
   drupal_set_message($msg);
-  drupal_goto('node/'. $node->nid);
+  if (node_access('view', $node)) {
+    drupal_goto('node/'. $node->nid);
+  }
+  else {
+    drupal_goto('');
+  }
 }
 
 /**

Log in or register to post comments

Comment #3

kps commented 12 November 2004 at 00:01

Hmm, on second thought I like this better:

--- node.module	Sat Oct 23 12:47:20 2004
+++ node.module	Thu Nov 11 18:56:54 2004
@@ -1376,8 +1376,13 @@ function node_submit($node) {
   }
 
   // Node was submitted successfully. Redirect to the viewing page.
-  drupal_set_message($msg);
-  drupal_goto('node/'. $node->nid);
+  if (node_access('view', $node)) {
+    drupal_set_message($msg);
+    drupal_goto('node/'. $node->nid);
+  }
+  else {
+    return $msg;
+  }
 }
 
 /**

Log in or register to post comments

Comment #4

dries commented 15 November 2004 at 09:58

Committed to HEAD and DRUPAL-4-5. I used the first patch because that makes for the most consistent approach: status messages are reported using drupal_set_message(). Thanks kps.