Posted by univate on June 20, 2011 at 4:48pm
45 followers
| Project: | Vote Up/Down |
| Version: | 7.x-1.x-dev |
| Component: | vud_node |
| Category: | task |
| Priority: | major |
| Assigned: | Unassigned |
| Status: | postponed |
Issue Summary
There are a few issues mainly with the vud_node module that isn't fully working in D7 for me.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| vud_node.patch | 9.19 KB | Idle | FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch vud_node_0.patch. This may be a -p0 (old style) patch, which is no longer supported by the testbots. | View details | Re-test |
Comments
#1
applied patch - no errors are appearing. the voting details tab appears correctly on content types with vote up/down turned on.
I do not have any voting widgets to test the actual voting though. (note: i did not test with normal node templates)
- Views integration is not working yet
Added: "Vote Up/Down: Node Widget" to a view , but it changes to "Broken/missing handler" after adding
- display suite integration is not working yet
no widgets appear
Is there any other ways to add the widget for further testing?
#2
actually it works! THANKS! not ajax yet. but after clicking the page reloads & it shows the vote count (voted on teaser). upon clicking into node & vote results, it shows my vote. thanks! Now we need to get ajax, views integration, and display suite integration going.
#3
Ajax is working for me... not sure it you need to clear cache or anything?
I'm not using views so haven't look into the views integration.
#4
+1
#5
+1
#6
+10 damage
#7
+10 circle of healing
sub
#8
sub
#9
Subscribe.
#10
subscribe
#11
subscribing
#12
+1 eager to see views and display suite integration
#13
RTBC++
This really should get into the code base by now, so we can keep moving forward, with other patches. I recommend we break off Display Suite, and (eg Panels integration) into separate tickets.
#14
Subscribe
#15
Subscribe
#16
rtbc++. i'd like to get this in so we can add more patches for the other problems.
#17
I guess I did not publish enough my plan for d7 #749438-39: Port Vote Up/Down to D7
Postponing for now instead of close, for feedback on #1295574: Remove vud_{node,comment,term} modules in favour of vud_field
#18
It Works fine for me. Except Ajax. I'm getting ajax is undefined error. Just now I noticed that ajax.js was not included. Any Solution?
#19
You need to include the Drupal AJAX library in vud.theme.inc, before ctools_add_js('ajax-responder');
function vud_widget_proxy
<?php
drupal_add_library('system', 'drupal.ajax');
ctools_add_js('ajax-responder');
ctools_include('ajax');
?>
#20
Are those fixes in git?
I see ctools_add_js and ctools_add_js but not drupal_add_library().
I would very much like to see vud_node continue, since a D6 site I manage needs to be migrated to D7 and vote counts on nodes and comments preserved..
#21
I don't see why we can't git these fixes into vud_node so that migrations from Drupal 6 are less painful.
I completely agree that the future should be vud_field. But since there is working code here why not let it live a little longer?
#22
thanks dankobiaka. thats solved my problem.
#23
The last git commit was June 16 by marvil07, so the above fixes are not flowing in..
mathankumarc: I was unable to apply the patch at the very top of this issue to git HEAD, what branch are you using?
UPDATE: use "git apply" as opposed to "patch < PATHCHNAME"
Changing the thread to active since its an issue that definitely interests some of us.
#24
vud_node.patch queued for re-testing....didn't really mean to re-test it, but based off the comment above me I wanted to make sure the patch worked.
I applied the patch and it cleaned up errors on my node page, but I still don't see the ability to add a vote up/down field on my node.
#25
Its easy to test manually:
mkdir vud_hackcd vud_hack
git clone --branch 7.x-1.x http://git.drupal.org/project/vote_up_down.git
cd vote_up_down
wget http://drupal.org/files/issues/vud_node_0.patch
UPDATE: Trying with 'git apply'
git apply --stat vud_node_0.patch
.cvsignore | 3 --
vud.install | 4 +-
vud.module | 25 +++++++++-----
vud.theme.inc | 2 +
vud_node/vud_node.module | 80 +++++++++++++++++++++++++++++++++-------------
git apply vud_node_0.patch
vud_node_0.patch:41: trailing whitespace.
error: .cvsignore: No such file or directory
Is there a way to tell git apply to continue despite .cvsignore?
(Well for now, I just edited the patch and deleted the first few lines)
And, also, then added the line and noted above for vud.theme.inc:
drupal_add_library('system', 'drupal.ajax');
#26
Could we please get the cumulative fixes committed, as I'm getting confused. I had developed other fixes in parallel (see #749438) and find it hard to keep track.
#27
The last submitted patch, vud_node.patch, failed testing.
#28
Is there anywhere where i can get a .zip file of this module anywhere i have looked everywhere and cant download huge files at work. is there any other alternative? at the moment im running a local version of this on my computer.
#29
@jacobf: Hey Jacob, welcome to Drupal & drupal.org! The module is available in both .zip & .tar.gz format in the project's page here: http://drupal.org/project/vote_up_down (scroll down to the "Downloads" section). I frankly don't understand what you mean by "huge" files. Both downloads are at the most around ~50-60kb.
Now, I am "obliged" to "smack you once across your head" mate ;) ...Please don't ask questions non-related to topics because it is frowned upon and considered rude here (you might see people refer to such off-topic questions as "issue hijacking"). It only adds "noise" to an issue where people try to solve a single specific problem. It makes it a very tedious job to try to read through and grok things - especially in issues with a lot of comments. It is not only your question, but the fact that someone else needs to reply to your question with an extra comment (like I was "forced" to do now).
Next time you need help with something:
- first search through the documentation
- then search in each module's issue queue (the "Issues for [project_name_here]" section on the right sidebar of each project) to see if your question has been asked and answered before
- if the above two steps failed to bring results, then file a new issue with your question and remember to select "support request" at the issue's category drop-down menu.
Now, an admin should delete both our comments ;)
#30
I am using the dev version "Last updated: November 25, 2011 - 12:42", and I am still getting these errors:
Notice: Use of undefined constant NODE_BUILD_PREVIEW - assumed 'NODE_BUILD_PREVIEW' in vud_node_node_view() (line 147 of \sites\all\modules\vote_up_down\vud_node\vud_node.module).
Notice: Use of undefined constant NODE_BUILD_SEARCH_INDEX - assumed 'NODE_BUILD_SEARCH_INDEX' in vud_node_node_view() (line 148 of \sites\all\modules\vote_up_down\vud_node\vud_node.module).
Notice: Use of undefined constant NODE_BUILD_SEARCH_RESULT - assumed 'NODE_BUILD_SEARCH_RESULT' in vud_node_node_view() (line 149 of \sites\all\modules\vote_up_down\vud_node\vud_node.module).
Notice: Use of undefined constant NODE_BUILD_RSS - assumed 'NODE_BUILD_RSS' in vud_node_node_view() (line 150 of \sites\all\modules\vote_up_down\vud_node\vud_node.module).
Notice: Undefined property: stdClass::$build_mode in vud_node_node_view() (line 152 of \sites\all\modules\vote_up_down\vud_node\vud_node.module).
Notice: Undefined variable: a3 in vud_node_node_view() (line 161 of \sites\all\modules\vote_up_down\vud_node\vud_node.module).
Notice: Undefined variable: a3 in vud_term_node_view() (line 82 of \sites\all\modules\vote_up_down\vud_term\vud_term.module).
Notice: Use of undefined constant NODE_BUILD_PREVIEW - assumed 'NODE_BUILD_PREVIEW' in vud_node_node_view() (line 147 of \sites\all\modules\vote_up_down\vud_node\vud_node.module).
Notice: Use of undefined constant NODE_BUILD_SEARCH_INDEX - assumed 'NODE_BUILD_SEARCH_INDEX' in vud_node_node_view() (line 148 of \sites\all\modules\vote_up_down\vud_node\vud_node.module).
Notice: Use of undefined constant NODE_BUILD_SEARCH_RESULT - assumed 'NODE_BUILD_SEARCH_RESULT' in vud_node_node_view() (line 149 of \sites\all\modules\vote_up_down\vud_node\vud_node.module).
Notice: Use of undefined constant NODE_BUILD_RSS - assumed 'NODE_BUILD_RSS' in vud_node_node_view() (line 150 of \sites\all\modules\vote_up_down\vud_node\vud_node.module).
Notice: Undefined property: stdClass::$build_mode in vud_node_node_view() (line 152 of \sites\all\modules\vote_up_down\vud_node\vud_node.module).
Notice: Undefined variable: a3 in vud_node_node_view() (line 161 of \sites\all\modules\vote_up_down\vud_node\vud_node.module).
Notice: Undefined variable: a3 in vud_term_node_view() (line 82 of \sites\all\modules\vote_up_down\vud_term\vud_term.module).
Are the changes mentioned above supposed to fix these; and have the changes not been put in the dev version?
thanks
#31
Where did you download that dev version from? I only see:
vote_up_down 7.x-1.x-dev
Posted by marvil07 on March 11, 2011 at 6:57am
Edit: My mistake, that same version was modified on the date you mentioned.
#32
same problem as reported iRex.
Error occurred when I try edit a node.
I use a just downloaded version.
#33
vud_node.patch queued for re-testing.
#34
The last submitted patch, vud_node.patch, failed testing.
#35
I patched by patch which is attached to the first post on this thread. it help for error submitted by iRex.
could you put this patch in repository?
#36
I posted a patch on #1402758: Remove user votes page in favour of views that overlaps some with this. I think it's got a cleaner approach to vud_user_votes() though.
#37
Luna Vulpo, I don't think you should be changing vud_update_6200(). It's designed to be run in D6… it should probably be removed and replaced by a hook_update_last_removed() that documents it's been removed.
#38
As mentioned on comment 17, the real reason I am not applying this changes is because I want to move to "the field way", which is basically use vud_field as the base for all.
Postponing again. This issue probably will become "Port vud_node on top of vud_field", when #1363928: Upgrade paths from vud_{node,comment,term} to vud_field is ready.
#39
very nice, very need, very D7 way
#40
For anyone using this, here is an updated patch for to latest dev.
#41
Hi all,
How can I sponsor development of this module for D7? I really need this to launch one of my sites. I'm not really sure how "sponsoring" works.
Thank you,
J.R. Merlan
Klucid.com
#42
@klucid: Find someone who's willing to work on it and agree upon a fee.
#43
Is this the proper thread to discuss? I posted to Drupal Paid Services last week: http://drupal.org/node/1402818)
#44
guys are running to get this module on D7, may think of flag first, or rate, they can provide similar features.
#45
@klucid, you'll really want to get buy in from the maintainer. i'd done a little work on this and they weren't really receptive to changes at this point. so the risk is that you'll pay someone to work on it, getting working on your site and then have the module go in a different direction and then find yourself with a custom fork of it.
#46
I'm proposing to create a 2.x branch for the new field-based approach and have the 1.x branch be more of a straight port of the module from D6.
#47
Thanks all, for your input. I think I'm going with the Rate module. it seems to do exactly what I need.
http://drupal.org/project/rate
#48
Subscribe.
#49
Welcome @modua! Please read this: Stop subscribing, start following