Drupal 7 functions [#1194322]

I ran this module through coder and got a couple of critical errors for functions that have changed in drupal 7. I updated them to what the Drupal 7 api had and made a patch. The new functions for hook_block should be reviewed.

Comment	File	Size	Author
	drupal7functions.patch	3.14 KB	erynn

Comments

Comment #1

johnbarclay commented 20 June 2011 at 18:29

Assigned:

Unassigned

» johnbarclay

Thanks. Appreciate you looking into this. Many of these are false positives. The functions are not core hooks, they are pseudo hooks from the accessible module.

The bug is in the coder module, which should recognize that there is no module named "accessible_fix_accessibility_api_data" so the hook implementation:

accessible_fix_accessibility_api_data_alter_block

is actually an implementation of "hook_accessibility_api_data" not "hook_alter_block"

Try to look toward the simpletests for expected behavior and a step through debugger to see if hooks are behaving correctly.

I would look at the 2.0 version for bug fixes and coder reviews. The 3.0 is new and geared toward reworking the module to integrate with accessible content module and potentially a common api. Its possible no one is even working on 3.0. For this to even get started it will require some group thought that hasn't happened yet.

I'll try to get the simpletests working again in 2.0.