Download & Extend
jPlayer » Issues

jPlayer breaks if the same player is embedded multiple times on a page

Posted by deviantintegral on June 20, 2011 at 6:29pm
Project:jPlayer
Version:7.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

This is a significant issue if a jPlayer is embeded in a View using Quicktabs, as only the first jPlayer is functional.

Login or register to post comments

Comments

#1

Posted by deviantintegral on June 20, 2011 at 6:30pm
Status:active» needs review
AttachmentSize
1194384.1-unique_player_ids.patch 2.81 KB

#2

Posted by deviantintegral on June 20, 2011 at 6:57pm

The patch in #1 helps when a view is displayed multiple times on a page, but only if all of the players are loaded on the initial request. This patch adds the request time to the ID, so that any future players added to the page will have a unique ID as well.

AttachmentSize
1194384.2-unique_player_ids.patch 3.81 KB

#3

Posted by deviantintegral on September 22, 2011 at 2:42pm
Version:6.x-1.0-beta3» 7.x-2.x-dev
Status:needs review» patch (to be ported)

I committed the patch from #2 to the 6.x-1.x branch.

#4

Posted by deviantintegral on September 22, 2011 at 5:45pm
Status:patch (to be ported)» fixed

I've pushed up the following commits. Note that the parameters for theme('jplayer') have changed, primarily to ensure that any entity type can be themed.

  • 63b2bba Issue #1194384: Ensure that player IDs are always unique.
  • 72affad Issue #1194384: Add the request timestamp to the ID to ensure uniqueness across AJAX requests.
  • 153995d Issue #1194384: Correct hook_field_formatter_view() to use the same parameter names as the hook itself.

#5

Posted by System Message on October 6, 2011 at 5:51pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here