This is a significant issue if a jPlayer is embeded in a View using Quicktabs, as only the first jPlayer is functional.

CommentFileSizeAuthor
#2 1194384.2-unique_player_ids.patch3.81 KBdeviantintegral
#1 1194384.1-unique_player_ids.patch2.81 KBdeviantintegral

Comments

deviantintegral’s picture

deviantintegral commented
Status: Active » Needs review
StatusFileSize
new 1194384.1-unique_player_ids.patch2.81 KB
deviantintegral’s picture

deviantintegral commented
StatusFileSize
new 1194384.2-unique_player_ids.patch3.81 KB

The patch in #1 helps when a view is displayed multiple times on a page, but only if all of the players are loaded on the initial request. This patch adds the request time to the ID, so that any future players added to the page will have a unique ID as well.

deviantintegral’s picture

deviantintegral commented
Version: 6.x-1.0-beta3 » 7.x-2.x-dev
Status: Needs review » Patch (to be ported)

I committed the patch from #2 to the 6.x-1.x branch.

deviantintegral’s picture

deviantintegral commented
Status: Patch (to be ported) » Fixed

I've pushed up the following commits. Note that the parameters for theme('jplayer') have changed, primarily to ensure that any entity type can be themed.

  • 63b2bba Issue #1194384: Ensure that player IDs are always unique.
  • 72affad Issue #1194384: Add the request timestamp to the ID to ensure uniqueness across AJAX requests.
  • 153995d Issue #1194384: Correct hook_field_formatter_view() to use the same parameter names as the hook itself.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.