Currently, features completely ignores the order when rebuilding multiple features, for example using drush or installation profiles, and uses alphabetical order instead, which may cause dependencies to fail. system_rebuild_module_data() already built the dependency graph, however features_get_features() doesn't make use of it.

CommentFileSizeAuthor
#1 features-dependencies-1195432.patch1.98 KBsmk-ka

Comments

smk-ka’s picture

smk-ka commented
Status: Active » Needs review
StatusFileSize
new features-dependencies-1195432.patch1.98 KB

Added sorting of features according to dependency information set by system_rebuild_module_data(). Code has mostly been taken from install_profile_modules().

This patch is a prerequisite for the performance patch at #1188066: Excessive rebuilding if installing more than one feature at a time.

febbraro’s picture

febbraro commented
Issue tags: +D7 stable release blocker

Adding a tag for webchick

febbraro’s picture

febbraro commented
Status: Needs review » Patch (to be ported)

Nice poach, thanks! Committed to 7.x branch. http://drupalcode.org/project/features.git/commit/64c8e8f

hefox, interested in this for D6?

febbraro’s picture

febbraro commented
Issue tags: -D7 stable release blocker

Removing tag for d7

febbraro’s picture

febbraro commented
Version: 7.x-1.x-dev » 6.x-1.1

  • febbraro committed 64c8e8f on 8.x-3.x 
    Issue #1195432 by smk-ka: Use dependency information when importing
  • febbraro committed 97cd892 on 8.x-3.x
    Issue #1195432: Fixing admin screen regression