Remove unnecessary access administration pages checks [#11958]

The links being made in the comment module link to pages which didn't check for 'access administration pages', the creation of those links shouldn't need to check that either.

The MENU_ITEM_GROUPING type only shows a menu item if it has children, which seems ideal for /admin.

Only the help module uses the 'access administration pages' permission now. Perhaps someone can find out a way to remove that before 4.6 and give us one less permission.

Comment	File	Size	Author
	remove_access_admin.diff	1.43 KB	drumm

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Dries CreditAttribution: Dries commented 23 October 2004 at 16:07

+1 for removing this permission, however I'm not going to commit this patch yet until we manage to remove the remaining instance in the help module. Thoughts?

Comment #2

TDobes CreditAttribution: TDobes commented 24 October 2004 at 01:11

I'd absolutely love to get rid of this permission. It's totally unnecessary and confusing from a user's perspective.

Here's a thought: could we make the admin->help menu item also act as a MENU_ITEM_GROUPING, and then set it up so that the individual modules register their help menu items rather than help.module? In this way, the modules would each be able to display or not display their help pages based upon whether the current user has permission to administrate each modules.

A more radical idea might be to eliminate the admin-> help page altogether... To me, it makes more sense to locate each module's help as a subpage of that particular module's admin page rather than as a subpage of a global "help"... I'm not sure if others agree with me on this, though. A case could certainly be made for the logic of placing all the help in one spot... I just don't honestly believe any admin would ever visit that spot... instead, they would click through the admin pages and click the "more help" links when confused.