If you have an image field when you are editing a term.

Click browse, find a file. Upload. Then the image field is completely missing from the UI so when you hit save changes, you have no image saved.

Bug is the same on ie8, ie9 and chrome. Latest dev version of taxonomy manager.

CommentFileSizeAuthor
#7 issue_1195940.patch4.05 KBserbanbjd

Comments

RumpledElf’s picture

Priority: Major » Critical

To make it worse, once you have images in your taxonomy (I'm adding images to a 300 strong taxonomy and it is taking ages) taxonomy manager will delete or mix up your images, so all your terms appear with the same image - but then when you look later they actually HAVE the same image (or no image at all), thus undoing all your work.

This is a really really really awful bug.

Taxoman’s picture

Subscribing (not confirming)

IcanDivideBy0’s picture

Subscribing

_redfog’s picture

Subscribing

dynamicdan’s picture

Big scary issue!

I noticed that the 're-oder' icon shows up on the file field. I'm guessing some CSS/JS selectors are not working properly for this field type... Probably due to a non-generic concept of handling taxonomy fields.

RumpledElf’s picture

Any updates on this one? Its getting quite annoying dealing with very large taxonomies with the core interface, would be fantastic to be able to use this module instead.

serbanbjd’s picture

StatusFileSize
new4.05 KB

This changes made it work for me. the problem lies with file_field_widget_submit function, that assumes the image field is in the $form, not in $form['term_data']. i have added a modified version of the function into taxonomy manager module, and altered the image fields to use it instead of the original one.

i hope i made the patch right, i never committed a patch before.

OnkelTem’s picture

Subscribing.

Also, when clicking "UPLOAD" button, I get the following error:

Warning: Invalid argument supplied for foreach() in file_field_widget_submit() (line 760 of (...)/www/modules/file/file.field.inc).
Warning: array_values() expects parameter 1 to be array, null given in file_field_widget_submit() (line 767 of (...)/www/modules/file/file.field.inc).
Notice: Undefined index: field_test_image in file_ajax_upload() (line 270 of (...)/www/modules/file/file.module).
Notice: Undefined index: #suffix in file_ajax_upload() (line 279 of (...)/www/modules/file/file.module).
xuxizh’s picture

Subscribing

badung’s picture

Thanks for the OnkelTem's patch!

Taxoman’s picture

This issue has had "critical" status for almost a year, is it anywhere near RTBC?

mh86’s picture

Status: Active » Fixed

I did a lot of debugging and testing, including patch from #7. Nevertheless I couldn't really get it working, there were always some parts broken.
Thus I decided to hide file fields on the term data form in the meanwhile and link them to the original taxonomy form.
To really get it working (without huge hacks) we would either need a different form architecture of the Taxonomy Manager or different file fields.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Taxoman’s picture

Status: Closed (fixed) » Fixed

So actually it's a workaround to avoid having to fix it? That is ok for now as long as this actually means that the scary behaviour reported in #1 is not happening anymore: "taxonomy manager will delete or mix up your images".

Please confirm that that bug has been removed with the latest -dev version.

mh86’s picture

yep. It worked in my scenario, further testing is of course always welcome.
As explained in my previous post, fixing this is really really hard and that's why I decided to go with the workaround.

Fix is included in the latest dev and beta3.

Taxoman’s picture

Component: User interface » Code
Status: Fixed » Closed (won't fix)

ok, so even though the workaround has been implemented, the core issue here is a wontfix for now. Adjusting accordingly, could help make it easier to find it back later also.

Taxoman’s picture

Status: Closed (won't fix) » Closed (fixed)

hm, well, on second thought it is not entirely correct to make it a wontfix either, what do you think?