coding standards cleanup :)

CommentFileSizeAuthor
#2 l10_client_css-2.patch8.75 KBdroplet
10n_client_css.patch8.76 KBdroplet

Comments

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Needs work

Some of your changes make the last ; characters go away. That looks like a bug. Otherwise looks good, thanks :)

droplet’s picture

droplet commented
Status: Needs work » Needs review
StatusFileSize
new l10_client_css-2.patch8.75 KB
jacine’s picture

jacine
she/her
Location New York
commented

Line height values should not have units: http://meyerweb.com/eric/thoughts/2006/02/08/unitless-line-heights/

Would be nice to remove them.

droplet’s picture

droplet commented
Assigned: droplet » Unassigned
Issue tags: +[coding standards cleanup] l10n_client.css

@Jacine,

my first patch to reformat the css file only, no style changes. it can be done in separated issue :)

Thanks.

jacine’s picture

jacine
she/her
Location New York
commented

Was trying trying to help "Cleanup l10n_client.css" (which is the title of this issue) and push this along with a review, but yes, you can do it in another issue.

SebCorbin’s picture

SebCorbin commented
Status: Needs review » Fixed

Committed, thanks !

Automatically closed -- issue fixed for 2 weeks with no activity.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
Issue tags: -[coding standards cleanup] l10n_client.css