Due to a rather strange stock mechanism we need to implement in a project of ours, we need to do something when stock is adjusted by the up_multi module.

To this end I've patched the up_multi_stock_adjust function in up_multi.module to provide a hook named up_multi_stock_adjust.

Could this patch be integrated into the dev branch for 6.x ?

(BTW, I also fixed a typo in the return query, adding accolades around the name of the table to select the new stock level from)

CommentFileSizeAuthor
#4 hook_up_multi_stock_adjust.patch1.27 KBrhmtts
hook_up_multi_stock_adjust.patch1.71 KBrhmtts

Comments

rbayliss’s picture

rbayliss commented

Haven't had a chance to review this yet, but can't this be done with conditional actions?

rhmtts’s picture

rhmtts commented

The conditional actions supplied by up_multi themselves call up_multi_stock_adjust, so rather than wrap the stock adjustment process in a whole bunch of "stuff" (conditional actions and such) that most likely duplicate a lot of functionality, I figured it'd be cleaner to just plug into the process in one place only.

Conceptually this seems simpler to me.

rbayliss’s picture

rbayliss commented

Yeah, I agree you'd want to keep it all in a single conditional action. My initial reaction was that this doesn't need to go into Uberpos, since you could pretty easily write a custom conditional action to replace the default one, but since we're managing stock completely outside of Ubercart in up_multi, I can see where this would make sense. One comment though... Instead of using a return value from the hook invocations, let's do something like this:

foreach (module_implements('up_multi_stock_adjust') as $module) {
    //Invoke function directly so we can pass by reference.
    $function = $module . '_up_multi_stock_adjust';
    $function($sku, $qty, $location);
}

Then the hooks can accept the parameters by reference and change them as needed. I think this is cleaner and requires less error handling code in up_multi.

rhmtts’s picture

rhmtts commented
StatusFileSize
new hook_up_multi_stock_adjust.patch1.27 KB

You're right, that's much cleaner.

Attached is the complete patch.

I've also added another thing: it seems there is no way for products to be added to the up_store_stock table automatically. So either you have to add them manually (as we've done up until now) or you add them the first time the stock is adjusted, inside the up_multi_stock_adjust function (which seems to me to make the most sense - by the time you get there it's very certain that you want an entry for the given product in te given location).