I would really like to use the setupCallback function.

JavaScript function that is called right after the carousel is completely setup. One parameter is passed: The instance of the requesting carousel.

It's currently not supported in this module, and if I overwrite the libraries in the module with 0.2.8, I get all sorts of problems...

CommentFileSizeAuthor
#11 jcarousel_update-1196558-8-make.patch40.96 KBemackn
#8 jcarousel_update-1196558-8.patch40.99 KBzambrey
#3 jcarousel_update_to_0.2.8-1196558.patch40.99 KBtd540

Comments

quicksketch’s picture

quicksketch
he/him
commented

Thank, I thought we were running 0.2.8 already, but you're correct we're only on 0.2.7. Could you describe "all sorts of problems"?

td540’s picture

td540 commented

Turns out it was just a small CSS issue :)

Apparently the 0.2.8 version does not add overflow:hidden to the jcarousel-clip-horizontal and jcarousel-clip-vertical divs. So I just had to add it to my custom skin css.

td540’s picture

td540 commented
Status: Active » Needs review
StatusFileSize
new jcarousel_update_to_0.2.8-1196558.patch40.99 KB

Here's a patch.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Version: 6.x-2.4 » 6.x-2.x-dev
Issue tags: +Needs backport to D7

Is this duplicate issue #1009142: jCarousel callback options do not work

quicksketch’s picture

quicksketch
he/him
commented

@andypost: That issue (newly re-opened) looks like a different request.

Crell’s picture

Crell commented

I've applied this patch to the 7.x-2.x branch and it's working fine for me there so far.

td540’s picture

td540 commented

Any chance of quickly wrapping this into a new release soon?

zambrey’s picture

zambrey commented
StatusFileSize
new jcarousel_update-1196558-8.patch40.99 KB

bump, nothing fancy here.
Fixed whitespace warning.

dkingofpa’s picture

dkingofpa commented

What is the minimum supported jQuery version for jCarousel plugin version 0.2.8? The jQuery Update module only brings D6 up to jQuery 1.3.2.

emackn’s picture

emackn commented

It applies cleanly to D7 dev branch and 2.4-alpha3.

emackn’s picture

emackn commented
StatusFileSize
new jcarousel_update-1196558-8-make.patch40.96 KB

Here's a make compatible patch.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs review » Fixed

Committed to both 2.x branches.

What is the minimum supported jQuery version for jCarousel plugin version 0.2.8? The jQuery Update module only brings D6 up to jQuery 1.3.2.

The jCarousel library works with any version of jQuery 1.2.3 (the version that ships with Drupal 6 core) or higher. You can use jCarousel with or without any jQuery Update.

td540’s picture

td540 commented
Status: Fixed » Closed (fixed)

Works great, thanks :)