Orders are now fieldable entities, so we have field and display settings in the admin pages, which includes a list of all order panes. But making changes to the panes here doesn't do anything; you have to use the "panes" tab for this, which is confusing. We should remove the panes tab and make the field/display settings tab work as expected.

Comments

longwave’s picture

Status: Active » Needs review
StatusFileSize
new1.99 KB

This patch changes uc_order_view() to use the display settings at /admin/store/settings/orders/display so fieldable entities can be ordered alongside panes.

It also removes the "invoice" and "print" view modes, as they aren't actually implemented, and I can't see an easy way of adding them alongside the current invoice theming.

longwave’s picture

StatusFileSize
new33 KB

This patch builds on #1 and changes the order edit form to use the field settings at /admin/store/settings/orders/fields.

It also removes theme_uc_order_edit_form() and the need for the "edit-theme" order pane op.

longwave’s picture

StatusFileSize
new33.97 KB

This one handles the "customer" view mode better by altering /admin/store/settings/orders/display/customer (when custom view modes are enabled) to remove panes that are not available to customers.

longwave’s picture

Status: Needs review » Needs work

Committed #1.

#3 no longer applies and needs work.

longwave’s picture

Status: Needs work » Needs review
StatusFileSize
new8.61 KB

Reviving this from the dead. This patch removes the four tabs full of checkboxes at /admin/store/settings/orders, in favour of using the "manage display" tab to rearrange the panes for admin and customer order view pages. It also removes the ability to hide panes on the order edit form, as I am not sure this was ever particularly useful. Reordering panes on the order edit form has always been broken in 7.x as far as fields are concerned, fixing that can perhaps be handled in a followup.

longwave’s picture

Status: Needs review » Fixed

Committed #5.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.