Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
theme
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Jun 2011 at 16:28 UTC
Updated:
31 Aug 2018 at 13:15 UTC
Jump to comment: Most recent
Comments
Comment #1
mjohnq3 commentedAdded tag
Comment #2
mjohnq3 commentedRemoved support for color module.
Comment #3
mjohnq3 commentedAdded support for local.css stylesheet.
Comment #4
mjohnq3 commentedChanging priority according to the new priority guidelines.
Comment #5
ao2 commentedQuickly run the code through the coder module http://drupal.org/project/coder and it just reports “” for coolness_default.inc and template.php
Ciao,
Antonio
Comment #6
mjohnq3 commentedThanks. I did notice that when I ran the files through coder. However, after looking at several core (Bartik, Garland, Seven) and contrib (Fusion, AdaptiveTheme) themes, I found that they're not using the @file block in similar locations either.
Comment #7
mjohnq3 commentedChanging priority according to the new priority guidelines.
Comment #8
tim.plunkettDoes #2 say *removed* support for the color module? Why would you do that?
Comment #9
mjohnq3 commentedFirst, I feel that since the color module and its settings are not inherited by, and must be added to, sub-themes, supporting it is completely optional and in this particular case, a design issue and not a technical one.
The visual design of this theme contains carefully chosen colors. Providing support for the color module, while convenient, would allow colors to be added which are not part of the original scheme. In addition, Skinr support is provided to allow color choices, within the original scheme, to be selected for block backgrounds and borders. In the future I may add Skinr settings for additional elements.
Comment #10
klausiyou have already an application going on in #1248082: [D7] Liquid Coolness, let's focus on that one.
Comment #11
mjohnq3 commented@klausi
They are two different themes: Coolness is fixed width; Liquid Coolness is fluid width.
Comment #12
klausiYes, but we are approving you only once ;-)
Comment #13
mjohnq3 commentedOk, that makes sense. I'll work on the Liquid Coolness issues.
Comment #14
avpaderno