There are two places in the code where dh_modulus and dh_gen is attempted to be used from the request. If the client is a Drupal OpenID client, these will not be provided. The second place where these are used, isset() checks lead them in. However, the first place they are neither checked neither used later in that function. Therefore it looks like entirely safe to remove them.

CommentFileSizeAuthor
dh-modulus-gen-notices.patch807 bytesgábor hojtsy

Comments

anarcat’s picture

Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.