MobStac Drupal module is achieves the following

  • It redirects the mobile traffic of drupal publishers to their MobStac powered mobile site, to achieve this the plugin inserts a javascript in the of the output page.
  • It exposes a REST API to the MobStac backend which helps MobStac in rendering the mobile site in the best possible manner by creating sections, pages, posts etc.
  • It also displays the stats of the mobile traffic on the drupal dashboard and intimates the MobStac backend of any newly published posts.

Project Page http://drupal.org/sandbox/shivanshtyagi/1147626

Comments

ParisLiakos’s picture

ParisLiakos commented
Priority: Major » Critical
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Priority: Critical » Normal
Status: Needs review » Needs work

Please take a moment to make your project page follow tips for a great project page.

Please take a moment to make your README.txt follow the guidelines for in-project documentation.

mobstac.info seems like a mistake that should be removed.

Is admin/mobstac/mobstac_drupal for admin users or anyone? Currently the access callback lets anyone see it which doesn't seem to make sense with the prefix of "admin" in the URL.

return t('<iframe scrolling="no" style="width:100%;height:500px;" src="http://b.mobstac.com/mpa/wpdash/?mak='.$mobstac_api_key.'"></iframe>');

Two thoughts on this code:
1. It probably shouldn't be wrapped in t() - t is for translating user interface text, not whole pages and not html.
2. You could use url to build the src attribute to protect against cross site scripting.

The administration menu callback should probably use "administer site conifguration" - which implies the user can change something - rather than "access administration pages" which is about viewing but not changing configurations.

On the form #description you should use the t() function and use double quotes instead of single quotes so you don't have to escape the '. Escaping single quotes makes it harder to translate strings.

Overall the module has very few comments. It would be great to get more comments.

http://drupalcode.org/sandbox/shivanshtyagi/1147626.git/blob/refs/heads/... looks like 3rd party code that may not be appropriately licensed. See http://drupal.org/node/66113 for why Drupal doesn't allow that code into git. You'll probably have to remove it and direct your users in how to download it (or use drupal_json instead?).

misc’s picture

misc commented

The applicant has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

shivanshtyagi’s picture

shivanshtyagi commented

The project has not been abandoned and still needs review. We have made changes to the module and uploading the new code.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Hi shivanshtyagi - the latest code on drupal.org is from June 23, but my review was in October. Can you upload the latest code and describe how you addressed the issues in my review?

When you do that please change the status back to needs work.

misc’s picture

misc commented

Still not any update in the git repo. Could you please upload the updated code and then switch to need review?

misc’s picture

misc commented
Status: Needs work » Postponed (maintainer needs more info)
klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Postponed (maintainer needs more info) » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.