Download & Extend

Obsolete .clearfix in default taxonomy-term.tpl.php template

Project:Drupal core
Version:8.x-dev
Component:taxonomy.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Front end, Issue summary initiative, needs backport to D7

Issue Summary

somehow a clearfix made it into the taxonomy-term.tpl.php, where its hard to se whats its actually doing here besides of making it impossible to float anything left or right of the terms.

this

should be this

Comments

#1

hurray and i forgot the code tagging...

somehow a clearfix made it into the taxonomy-term.tpl.php, where its hard to se whats its actually doing here besides of making it impossible to float anything left or right of the terms.

This

<div id="taxonomy-term-<?php print $term->tid; ?>" class="<?php print $classes; ?> clearfix">

should be this
<div id="taxonomy-term-<?php print $term->tid; ?>" class="<?php print $classes; ?>">

#2

Status:active» needs review

Here's a patch that removes the clearfix class.

AttachmentSizeStatusTest resultOperations
taxonomy-clearfix-1198088-01.patch557 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 34,229 pass(es).View details

#3

Title:die clearfix die - taxonomy-term.tpl.php dont want you.» Obsolete .clearfix in default taxonomy-term.tpl.php template
Status:needs review» reviewed & tested by the community

Looks good.

@mortendk: A clear issue title helps others to find issues, manages expectations, speeds up reviews, and most commonly leads to faster commits.

#4

@sun yup i was kinda fired up by the holy fire ;)

#5

Does this need to be fixed in 8.x too?

#6

Version:7.x-dev» 8.x-dev
Issue tags:+needs backport to D7

Yes, it needs to go into both. Oops.

#7

Tagging issues not yet using summary template.

#8

Status:reviewed & tested by the community» fixed

Committed to 7.x and 8.x. Thanks!

#9

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.