It's not clear under which conditions this happens, but occasionally, the post_body sent to Mollom contains the internal $form array key name of a CCK field instead of its value.

CommentFileSizeAuthor
#5 mollom.field-values.5.patch5.08 KBsun
#2 mollom.field-values.2.patch5 KBsun
#1 mollom.field-values.1.patch5 KBsun

Comments

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Needs review
StatusFileSize
new mollom.field-values.1.patch5 KB

Attached patch tries hard to reproduce the bug in a test.

I wasn't able to reproduce the "field_xyz[0][value" result in post_body, so I can only guess that this value must come from some other module -- if it was our own, it would be field_xyz][0][value (Form API ][ parents syntax).

However, the extended tests revealed that multiple value (CCK) fields are not taken over entirely (subsequent values overwriting the first).

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
StatusFileSize
new mollom.field-values.2.patch5 KB

Removed the term "CCK", as this patch applies to both D6 and D7.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
dries’s picture

dries commented

This look good to me. Feel free to commit this patch.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
StatusFileSize
new mollom.field-values.5.patch5.08 KB

Committed to 6.x-1.x. Forward-ported to D7, needs testbot confirmation.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Fixed

Committed to master, too.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 5b7809c on master, fai6, 8.x-2.x, fbajs, actions by sun: 
    Issue #1198192 by sun: Fixed 'field_xyz()][0][value' sometimes contained...

  • Commit 5b7809c on master, fai6, 8.x-2.x, fbajs, actions by sun: 
    Issue #1198192 by sun: Fixed 'field_xyz()][0][value' sometimes contained...