How to Remove "Post New Forum Topic" on Forum Container Main Page

Thanks Spydor for helping us develop in the Drupal way.

Forgive me, I'm neither a themer nor a developer (yet), just a humble content manager. I tried putting this at the end of my template.php:

/**
 * Format the forum body (and block containers from allowing posts).
 *
 * @ingroup themeable
 */
function _forum_display($forums, $topics, $parents, $tid, $sortby, $forum_per_page) {
  global $user;
  // forum list, topics list, topic browser and 'add new topic' link

  $vocabulary = taxonomy_get_vocabulary(variable_get('forum_nav_vocabulary', ''));
  $title = $vocabulary->name;

  // Breadcrumb navigation:
  $breadcrumb = array();
  if ($tid) {
    $breadcrumb[] = array('path' => 'forum', 'title' => $title);
  }

  if ($parents) {
    $parents = array_reverse($parents);
    foreach ($parents as $p) {
      if ($p->tid == $tid) {
        $title = $p->name;
      }
      else {
        $breadcrumb[] = array('path' => 'forum/'. $p->tid, 'title' => $p->name);
      }
    }
  }

  drupal_set_title(check_plain($title));

  $breadcrumb[] = array('path' => $_GET['q']);
  menu_set_location($breadcrumb);

  if (count($forums) || count($parents)) {
    $output  = '<div id="forum">';
    $output .= '<ul>';

    if (user_access('create forum topics')) {
      if (count($parents) > 1) {
      $output .= '<li>'. l(t('Post new forum topic.'), "node/add/forum/$tid") .'</li>';
      }
    }
    else if ($user->uid) {
      $output .= '<li>'. t('You are not allowed to post a new forum topic.') .'</li>';
    }
    else {
      $output .= '<li>'. t('<a href="@login">Login</a> to post a new forum topic.', array('@login' => url('user/login', drupal_get_destination()))) .'</li>';
    }
    $output .= '</ul>';

    $output .= theme('forum_list', $forums, $parents, $tid);

    if ($tid && !in_array($tid, variable_get('forum_containers', array()))) {
      $output .= theme('forum_topic_list', $tid, $topics, $sortby, $forum_per_page);
      drupal_add_feed(url('taxonomy/term/'. $tid .'/0/feed'), 'RSS - '. $title);
    }
    $output .= '</div>';
  }
  else {
    drupal_set_title(t('No forums defined'));
    $output = '';
  }

  return $output;
}

It didn't do anything. It didn't break the site either, which is nice. What am I doing wrong?
___
Drupal is a perfectly cromulent word.

if ($tid && !in_array($tid, variable_get('forum_containers', array()))) {
    $output .= '<div id="new-forum-post">'. l(t('Post new forum topic.'), "node/add/forum/$tid") .'</div>';
}

I haven't super-tested it though, so YMMV.

subscribing

Worked in my 6.16. Thanks, Farez.

Other than having to re-do that change every time there is an update? no...

That would only hide the action link from the root /forum listing. In order to hide the link on container listings, as well, you're also going to have to do a check to see if the current $forum_term is a container.

Below is an updated forum_menu_local_tasks_alter() that will achieve the desired result. Unfortunately, this change will be lost any time Drupal is updated. This change would ideally be merged into forum.module by a Drupal developer.

/**
 * Implements hook_menu_local_tasks_alter().
 */
function forum_menu_local_tasks_alter(&$data, $router_item, $root_path) {
  global $user;

  // Add action link to 'node/add/forum' on 'forum' sub-pages.
  if ($root_path == 'forum/%') {
    $tid = (isset($router_item['page_arguments'][0]) ? $router_item['page_arguments'][0]->tid : 0);
    $forum_term = forum_forum_load($tid);
    if ($forum_term) {
      $containers = variable_get('forum_containers', array());
      if (!in_array($forum_term->tid, $containers)) {
        $links = array();
        // Loop through all bundles for forum taxonomy vocabulary field.
        $field = field_info_field('taxonomy_forums');
        foreach ($field['bundles']['node'] as $type) {
          if (node_access('create', $type)) {
            $links[$type] = array(
              '#theme' => 'menu_local_action',
              '#link' => array(
                'title' => t('Add new @node_type', array('@node_type' => node_type_get_name($type))),
                'href' => 'node/add/' . str_replace('_', '-', $type) . '/' . $forum_term->tid,
              ),
            );
          }
        }
        if (empty($links)) {
          // Authenticated user does not have access to create new topics.
          if ($user->uid) {
            $links['disallowed'] = array(
              '#theme' => 'menu_local_action',
              '#link' => array(
                'title' => t('You are not allowed to post new content in the forum.'),
              ),
            );
          }
          // Anonymous user does not have access to create new topics.
          else {
            $links['login'] = array(
              '#theme' => 'menu_local_action',
              '#link' => array(
                'title' => t('<a href="@login">Log in</a> to post new content in the forum.', array(
                  '@login' => url('user/login', array('query' => drupal_get_destination())),
                )),
                'localized_options' => array('html' => TRUE),
              ),
            );
          }
        }
        $data['actions']['output'] = array_merge($data['actions']['output'], $links);
      }
    }
  }
}