Needs review
Project:
Advanced Help Injection and Export
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
24 Jun 2011 at 10:57 UTC
Updated:
17 Sep 2014 at 14:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
batje commentedwe use it. its nice.
Comment #2
aron novakinitial D7 version with really few testing.
Comment #3
aron novakplease test and report errors
Comment #4
soul88Hello, Aron.
I tried your version and it worked well for me, so big thanks. The only thing were some problems with exporting help to a separate module. Some funcitons were deprecated from core. And some other tiny things. So here is the fixed version:
Comment #5
kimpema commentedDrupal 7 port
Soul88's port works in great lines :
Some problems though :
1. get the following warnings when trying to associate a help with a content type or page as a whole - on the fields it works fine though
* Warning: array_combine() expects parameter 1 to be array, string given in drupal_map_assoc() (line 2658 of /home/grizzzly/drupal-7.2-0/apps/drupal/htdocs/includes/common.inc).
* Warning: Invalid argument supplied for foreach() in helpinject_injection_form() (line 229 of /home/grizzzly/drupal-7.2-0/apps/drupal/htdocs/sites/all/modules/contributed/helpinject/helpinject.module).
(actually upgraded 7.2 to 7.12 but dir name nchanged)
Subsequent page does not show : Path Granularity.
2. Anonymous users can see the help and navigate in it in a popup, but they also get the options edit, delete - of course clicking on the options gives them access denied. How to avoid getting them to see the options?
Many thanks already for the great work.
Comment #6
NotGoddess commentedHey-
I needed this for a Drupal 7 install so I pulled down the zip from #4.
Attached is a new version that addresses the first issue in #5 - I'm not entirely sure my solution was correct as I'm passing the entire menu ancestors back and it seems the original took off the base path. I'll probably be making further adjustments so if I see the logic, I'll adjust that.
I also addressed the export issue with files- the module needed to use file_unmanaged_copy for drupal 7 rather than file_copy so images are saved correctly. I saw it only took the thumbs created by the image_resize_filter and not the full-size linked image so I may see if I can address that but this works for now.
I haven't gotten to issue 2 yet but will address it when I get there. This is a great module and deserves to be ported/used. I'm happy to help if I can get a D7 version out.
Comment #7
batje commented@NotGoddes are you interested in becoming a co-maintainer for the Drupal 7 branch. If so, you could contact the current maintainers. That would be really great.
Comment #8
autopoietic commented#6 code seemed to work fine for me, though I kept getting the following error:
I traced the error to a conflict with the devel menu as rendered by admin module. Though this probably not a big problem for anyone, I have attached an amended version of #6 that checks that $elements is an array before passing it to element_children(), which fixes the the problem for me. I suppose this might help in the future if any other module produces the same conflict.
Comment #9
autopoietic commentedsee #8
Comment #10
technikh commentedThanks for the module. Installed module in #9
got this message while enabling the module.
Warning: Invalid argument supplied for foreach() in element_children() (line 6300 of /***************/docroot/includes/common.inc).FYI, this was on the page to enable book module.
Comment #11
technikh commentedgetting PDOException error when trying to edit existing help on this page http://****/helpinject/inject/path/node/add/page?destination=node/add/page
PDOException: SQLSTATE[HY093]: Invalid parameter number: parameter was not defined: SELECT r.title FROM {node_revisions} r INNER JOIN {node} n ON n.vid = r.vid WHERE r.nid = :r.nid; Array ( [:r.nid] => 499 ) in helpinject_injection_form() (line 249 of /************/docroot/sites/all/modules/helpinject/helpinject.module).Comment #12
technikh commentedthe help text on /helpinject/inject/form/page
should use the settings at /admin/content/book/settings
create link shouldn't always link to /node/add/book
Comment #13
sketman commentedI think this is an excellent and useful module. Are there plans for full D7 release please?
If not, could anybody recommend some working D7 alternative please?
Comment #14
sketman commentedI am not able to reach configuration page to export Help as a new module. At admin/config/helpinject I am getting error:
Other features work fine, I can see the icons next to form elements and inject book help texts there.
I am using fresh Drupal install, the latest stable 7.x version.
Comment #15
gettysburger commentedI tested this and am looking forward to having it work.
A few things. The instructions tell you to go to admin/build/helpinject to export a module, but the module seems to want me to go to admin/config/helpinject.
I looked at helpinject_settings and it seems to be looking for a variable called "helpinject_excluded_paths" which I could not find in the variables table.
Hope that helps. Thanks for a great looking module.