I think to match the standards used in other modules, this project should be shut down and moved to http://drupal.org/project/contextual_flyout_links instead.

The 'contextual-flyout-links' name leads to confusion in code and the filesystem, since everything else (including the module's own files) uses underscores.

Comments

jessebeach’s picture

jessebeach commented
Version: » 7.x-1.0

I don't think one can change the shortname once it's been created. It seems to be a read-only field on the node's edit page.

David_Rothstein’s picture

David_Rothstein commented

Yeah, you can't change it ... I think the only option would be to create a new project (and mark this one as deprecated)?

jessebeach’s picture

jessebeach commented

David, I don't know if this change is really worth the effort. Do you think it is? If you do, I'll make it.

David_Rothstein’s picture

David_Rothstein commented

Well, the Drupal Gardens version is using contextual_flyout_links already, so I thought that meant someone had to change (in order to make them consistent) or the d.o. code could never be merged in there? But maybe it doesn't actually mean that...

jessebeach’s picture

jessebeach commented
Status: Active » Closed (won't fix)

The naming of the project doesn't seem to have caused any trouble yet. Closing this given no activity for a while.

David_Rothstein’s picture

David_Rothstein commented

This will cause problems for Drupal Gardens when we want to deploy this module via Drush Make; we'll have to write some kind of update function to switch sites from having 'contextual_flyout_links' module enabled to 'contextual-flyout-links' instead.

However, I originally filed this issue when the module was still in -dev stage... It now has an official release and over 250 sites using it, so I guess it's too late to make this change without inconveniencing a lot of other people. We'll have to deal with this via custom code in Drupal Gardens.

markhalliwell’s picture

markhalliwell
Primary language English
commented
Status: Closed (won't fix) » Active

+1 I agree with David, trying to package, download or even trying to enable with Drush makes it harder with the name scheme. It SHOULD be moved.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Agreed this is super confusing for make files and packaging and I'm sad it wasn't fixed earlier. :(

blasthaus’s picture

blasthaus commented

+1 on this for Drush usability

katbailey’s picture

katbailey commented
Project: » Contextual Flyout Links
Version: 7.x-1.0 » 7.x-1.2
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.