Closed (fixed)
Project:
Nodewords: D6 Meta Tags
Version:
6.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
26 Jun 2011 at 17:08 UTC
Updated:
4 Jan 2014 at 00:53 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
dave reidI don't think this is necessary and creates more frustrating work. Those users should be switching to 6.x-2.0-alpha1 and we just need to make it clear on the 6.x-1.12 release notes and project page. At least not a critical task.
Comment #2
damienmckennaAt the very least we should add an update script that throws warnings and/or blocks the update if you attempt to run the update if the new 6.x-2.x code has been used.
Comment #3
damienmckennaThe following tables exist for both Nodewords v6.x-1.x-dev and v6.x-2.x-dev:
I've reviewed the schema for both tables and they look exactly the same. The next step is to examine the data created by both to see if there are any changes in what is actually stored.
Comment #4
damienmckennaPossible items:
Any others?
Comment #5
izmeez commentedsubscribing
Comment #6
hanoiisubscribe
Comment #7
damienmckennaComment #8
damienmckennaProblems:
Comment #9
damienmckennaThis patch should resolve the second issue, where it would try to re-run all updates when updating from a 6.x-1.12- version. It also will display the following message:
Comment #10
damienmckennaThis version deletes values from the 'system' table for the defunct submodules.
Comment #11
damienmckennaFixed the $ret values, improved the message slightly.
Comment #12
damienmckennaI've committed this code.
Comment #13
damienmckennaComment #14
virtuali1151 commentedThis is still not fixed... it is throwing the below error:
PHP Fatal error: Cannot redeclare nodewords_custom_pages_confirm_delete()
Comment #15
damienmckennaHow did you update the files? Are you sure all of the old files were deleted? In the fresh 6.x-1.x codebase the function nodewords_custom_pages_confirm_delete() only exists in nodewords.admin.inc, whereas in 6.x-1.12-x it was in nodewords_admin.admin.inc.
Comment #17
pbeakley commentedCannot redeclare nodewords_custom_pages_confirm_delete()
I just got this error as well, and I definitely deleted all the old files. WSOD, site's dead as a doornail now. :-/
Comment #18
damienmckenna@pbeakley: Please try deleting the Nodewords files again, make sure you don't have another copy of the module somewhere else in the site's directory structure, clear all site caches and then download 6.x-1.13 again.