Add imagecache support

  $preset_var = $teaser ? 'inline_teaser_preset' : 'inline_full_preset';

  if (module_exists('imagecache') && variable_get($preset_var, 'default') != 'default') {

$preset_var doesn't seem to be 'default' in any case.

-      list($width, $height) = getimagesize($file->filepath);
+      list($width, $height) = getimagesize(file_create_url($file->filepath));

seems to deal with another filepath issue. AFAIK, there are no open issues about inlined image filepaths currently. Can you explain this change?

Please do not include the module name in issues. I know, the recent posts listing doesn't display the project name for issues, but regarding project issue queues, these prefixes are not welcome.

It's almost needless to say that I like this patch very much... ;)

function theme_inline_img($file, $teaser) {
  $preset_var = $teaser ? 'inline_teaser_preset' : 'inline_full_preset';

  if (module_exists('imagecache') && variable_get($preset_var, '')) {

We should replace $teaser with $field in the arguments of theme_inline_img() to make the code more understandable and to remove duplicate conditionals from function calls. $teaser seems then to be replaceable by $field == 'teaser'.

Please also avoid changes to other code lines:

-  $title = ( $file->title ? $file->title : $file->filename );
+  $title = ($file->title ? $file->title : $file->filename );

and avoid double spaces

+    $presets =  _imagecache_get_presets();
...
+      '#options' =>  $options,

and adhere to Drupal coding guidelines:

+    $image = theme('imagecache',
+      variable_get($preset_var, 'default'),
+      $file->filepath,
+      $title,
+      $title,
+      array('class' => 'inline'));
// should be
+    $image = theme('imagecache', variable_get($preset_var, 'default'), $file->filepath, $title, $title, array('class' => 'inline'));

and

+      array('class' => 'inline', 'style' => 'width: '.$file->width.'px; height:'.$file->height.'px;'),
// should be
+      array('class' => 'inline', 'style' => 'width: '. $file->width .'px; height:'. $file->height .'px;'),

You might install Coder module to automate such tests.

Did you already test that Inline works the same way it did without this patch?

I've reworked your code and committed this feature to HEAD and DRUPAL-5.
Thanks for your help!