drupal_environment_initialize() passes wrong ini_set parameter

This is by design: we want to disable the cache limiter here. That said, it would be better to use an empty string instead of the invalid 'none' string.

Needs to be fixed in Drupal 8 first. This is a novice patch.

Looks good to me.

Note sure this is better. At least 'none' was self-explanatory. DamZ, care to clarify?

It doesnt matter. I tried to ask PHP internals http://news.php.net/php.internals/55781 as long as you send a string that does not have a predefined meaning it will send nothing.

Could we document this behaviour in the code comment a bit more?

Ok I gave this a shot since it looks relatively easy.

Thanks but it's not really the guidelines... the behaviour is , there are strings with predefined meaning and if we set it to anything else, nothing will be sent. "// Use a string without a predefined meaning to avoid PHP sending the session limited" in other words what php does is

if (isset($headers['cache_limiter'])) send_headers($headers['cache_limiter']);

Hi @barbi,

Thanks for taking this on. Are you still working on this issue? If not, we'll unassign it in a day or two so that someone else can give it a try. (Feel free to assign it back to yourself if you'd still like to work on it, as well.) Thanks!

Putting it back in the queue.

As Per chx said in #10, created a patch this .

Thanks @crazyrohila! A couple things I noticed with the new comment:

+++ b/core/includes/bootstrap.incundefined
@@ -572,7 +572,8 @@ function drupal_environment_initialize() {
+  // Use a string without a predefined meaning to avoid PHP sending the session limited

Inline comments should wrap at 80 characters or less, and end with a period. Also, this comment is a little confusing; can we re-word it to be more clear? (I realize this is what chx said originally.)

Also, I think this backports.

Made Some Changes, as I think that is a 'empty string' or null, not 'string without predefined meaning' .

Thanks @crazyrohila. I still don't know what "PHP sending the session limited" means, though (it sounds like poetry), and the comment still needs a period. Ideally we would explain a little more. Also, I guess it would be "an empty string". Thanks!

Hello. Hope I am not hijacking anyone's issue here, but since there was no activity I took a shot at this. Nice and easy issue to start with on core.

Simplified the inline comment a bit, hopefully it explains things correctly.

Alright, I think that comment does the trick. Thanks @eiriksm.

I believe I committed this yesterday but forget to update the 'Status' field.

Patch attached for backport.

(minor issue, but it caused me some confusion when debugging something)

Looks fine. The latest patch does solve the issue.

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/ddba1d9