when rules sends mail with no attachments:

Warning: Invalid argument supplied for foreach() in mimemail_html_body() (Zeile 352 von /home/xl/workspace/sanago/sites/all/modules/mimemail/mimemail.inc).

that line

foreach ($attachments as $a) {

gets a string served.

CommentFileSizeAuthor
#3 mimemail_1201154_02_d6.patch980 bytessgabe
#3 mimemail_1201154_02_d7.patch1.04 KBsgabe
#1 0001-fix-1201154-error-when-rules-sends-mail-with-no-atta.patch1.54 KBgeek-merlin

Comments

geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Active » Needs review
StatusFileSize
new 0001-fix-1201154-error-when-rules-sends-mail-with-no-atta.patch1.54 KB

patch flying in.

mimemail.rules.inc should also convert empty strings to arrays.
also removed a double "trim".

guillaumev’s picture

guillaumev commented

Also check here:
http://drupal.org/node/1066438#comment-4679920

sgabe’s picture

sgabe commented
Title: error when rules sends mail with no attachments » Check if attachments is an array and isn't empty
Status: Needs review » Fixed
StatusFileSize
new mimemail_1201154_02_d7.patch1.04 KB
new mimemail_1201154_02_d6.patch980 bytes

Thanks, committed on both branches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

hanskuiters’s picture

hanskuiters commented

Thanks for the D6 fix. Just needed it.