Don't reset mail system variable [#1201198]

We are using the smtp module to connect to sendgrid. We only want to use it when sending newsletters. Since we are paying for each mail using this third party smtp we dont want to use it for all mails. So we believe adding the smtp mail class is a better option than setting it for the whole site by default.

function smtp_enable() {
  $systems = array(
    'default-system' => 'DefaultMailSystem'
    'smtp-system' => 'SmtpMailSystem'
  )
  variable_set('mail_system', array('default-system' => 'SmtpMailSystem'));
}

Comment	File	Size	Author
#10	1201198-dont_reset_mail_system_variable-10.patch	792 bytes	ParisLiakos
#2	1201198_dont-reset-mail_system-variable.patch	792 bytes	ParisLiakos

Comments

Comment #1

fabianx commented 11 November 2011 at 17:38

Status:

Active

» Needs work

Could you please provide a patch instead?

Comment #2

ParisLiakos commented 16 November 2011 at 00:29

Status:

Needs work

» Needs review

Status	File	Size
new	1201198_dont-reset-mail_system-variable.patch	792 bytes

No,don't clear the mail_system variable and then set it:/
this is a more elegant way:

Then,domidc you could manipulate this variable as you wish without smtp or any other module interfering.
Also smtp wont screw other modules settings this way

Comment #3

ParisLiakos commented 5 December 2011 at 23:47

Title:	Add the mail class in hook enable instead of replacing the default one	» Don't reset mail system variable
Category:	feature	» bug

And this is a bug.

Comment #4

longwave

he/him

English

commented 8 December 2011 at 21:16

Priority:

Normal

» Major

This bug breaks any other contrib module that provides their own MailSystem and that was installed before SMTP. This affects at least Ubercart: #1364612: Ubercart don't work with smtp module?