Persistent shipping line item

I personally added a routine to delete the shipping line-item in submit_form() handler then use a drupal_goto() to refresh the page. You could maybe have look at this #1185954: After updating to Drupal Commerce 7.x-1.0-beta4 , Commerce Shipping throws serious errors or at the code that is taking care of the delete in checkout-review.

When a new shipping type is selected (submitted) the old one is removed:

// In case this order already have shipping line items, we need to remove them.
$order_wrapper = entity_metadata_wrapper('commerce_order', $order);
$delete_line_items = array();
foreach ($order_wrapper->commerce_line_items as $delta => $line_item_wrapper) {
  if ($line_item_wrapper->type->value() == 'shipping') {
    $order_wrapper->commerce_line_items->offsetUnset($delta);
  }
}
$order_wrapper->save();

I'm not sure how you are able to select the shipping item keep the old.

If the shipping item was removed when the option to select the shipping item was presented, you would make it possible to bypass the shipping costs.

It's up to site builders to decide how to handle this case, by standard I don't think the shipping module should delete anything. You should be able to handle this with rules alone.

Regarding SS in #6. You have based this upon the fact that you have your shipping selection at checkout. You could also have the shipping selection at the review step or some other step. I don't believe it's the commerce_shipping module's job to handle such cases. But maybe the module should create an action to make it easier to delete shipping items via rules.

I'll give this some thought, input is welcome.

I've added a Rules action to delete shipping line items on an order. Please test.

You need to have the rule invoked before the page is rendered, instead of reloading the page.

I've got the same problem that when a client goes to "Review" and decides to go back to add products to not pay the shipping the shipping is there in the "Checkout -> Shopping cart contents " (not in the new "Review".

@googletorp I saw "I've added a Rules action to delete shipping line items on an order."

Can you please tell me where to add the "delete-rule".

This is the rule I've got:

Data comparison:
Parameter: Data to compare: [commerce-order:commerce..., Operator: is lower than, Data value: 7000

Enable shipping method: PBCosmetics Shipping method:
Parameter: Order: [commerce-order]

So I add shipping-costs to an order when the order is less then 70€.
Do I need to create a new rule next to the actual one, for deleting shipping-costs when the order is more than 70€ ?

I encoutered the same problem, I finally created a little rule for cleaning the cart when the user goes back to checkout/command id but it's far from ideal.

Anyway, if it can help, here is what I did :

1) Create a rule
- EVENT : Select available shipping methods for an order
- CONDITION : custom php code to avoid infinite redirect loop (check that we have a shipping line) , code almost copyed from commerce_shipping_clear_order ...
$order_wrapper = entity_metadata_wrapper('commerce_order', $commerce_order);
$line_items_to_delete = array();
foreach ($order_wrapper->commerce_line_items as $delta => $line_item_wrapper) {
if ($line_item_wrapper->type->value() == 'shipping') {
$line_items_to_delete[] = $line_item_wrapper->line_item_id->value();
}
}
return count( $line_items_to_delete) > 0;
- ACTIONS
Remove all shipping items from an order
Page redirect (to checkout/[commerce-order:order-id])

It works on my site, but I'm not very satifyed with that. Would be far better to clean the order before it is rendered, thus avoiding the redirect.