This log entry:

custom filters: matched 'always spam' filter 1 times, added 200

Is not very useful for debugging which filter fired when developing.

Would it be possible to (a) allow us to give names to filters, and then (b) display the names of matching filters in the log, with (c) a fallback to the (possibly truncated) regex, if the name is not present? Thanks a lot

CommentFileSizeAuthor
#5 spam_filtid_0.txt2.14 KBnancydru
#4 spam_filtid.txt2.6 KBnancydru
#3 spamfilid.txt2.14 KBnancydru

Comments

jeremy’s picture

jeremy commented

I have a re-write in mind that will make it trivial to understand which filters affected content's spam rating. Hopefully I'll find the time to work on this sometime in the upcoming weeks or months. As things currently stand, it's not a trivial fix.

jeremy’s picture

jeremy commented
Status: Active » Postponed

Marking as postponed until 5.x-2.x.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Postponed » Needs review
StatusFileSize
new spamfilid.txt2.14 KB

This patch adds the filter # (scid) to the list on the admin page and then includes it on the log message so they can be tied together.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
StatusFileSize
new spam_filtid.txt2.6 KB

Updated to Oct 18 version.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
StatusFileSize
new spam_filtid_0.txt2.14 KB

Oops, also had another patch in it. This is correct now.

jeremy’s picture

jeremy commented
Version: 5.x-1.x-dev » 5.x-3.x-dev
Status: Needs review » Active

New features will be added in the 5.x-3.x version of the module. Bug fixes only for 5.x-1.x please.

Updating issue to be against 3.x, which will offer _much_ more useful debugging and logging.

jeremy’s picture

jeremy commented
Status: Active » Fixed

Enable debug logging to trace which filters are doing what to the overall score. Already provided in 5.x-3.x version of the module.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.