Drupal 5.0 support [#120300]

Comment	File	Size	Author
#3	geshifilter.module.txt	20.11 KB	executex
#2	changeswithwhitespace.patch	44.08 KB	mhutch

#1	geshifilter.info_.txt	129 bytes	mhutch
	changes.patch	12.36 KB	mhutch

Comment #1

mhutch CreditAttribution: mhutch commented 18 February 2007 at 15:37

File	Size
geshifilter.info_.txt	129 bytes

And the .info file -- for some reason couldn't add it to anon CVS for adding to the patch.

Log in or register to post comments

Comment #2

mhutch CreditAttribution: mhutch commented 18 February 2007 at 15:38

File	Size
changeswithwhitespace.patch	44.08 KB

And here's a version of the patch with whitespace changes of tabs to two spaces, as per Drupal guidelines.

Log in or register to post comments

Comment #3

executex CreditAttribution: executex commented 25 March 2007 at 17:00

File	Size
geshifilter.module.txt	20.11 KB

There is a problem with the $types variable. In debug mode, $types[] array is empty every time, even though the settings are set. There doesn't seem to be anything wrong with the code, unless $format messed up a lot. In other words, the filter either highlights with default lang, or just a plain Geshi css. type=, doesn't work at all, it's detected, but $types is empty.

Could you please upload a FULLY TESTED version of the .module without the "changes" crap, because it really isn't working with different languages.

Log in or register to post comments

Comment #4

mhutch CreditAttribution: mhutch commented 25 March 2007 at 18:06

That's weird; it works absolutely fine for me. Have you enabled the languages you need in the filter's "configure" options (admin/settings/filters//configure)?

BTW, the attachment to the original issue lacks the whitespace changes. But the "whitespace changes only affect the appearance of the module's source.

Have you tried the http://drupal.org/node/112067 version?

Log in or register to post comments

Comment #5

executex CreditAttribution: executex commented 25 March 2007 at 20:10

Well It detects the tag at some points. I think I mixed it up before which is why I thought it wasn't detecting the tag.
I was typing language="" instead of type="",
anyway, I fixed that, but now in debug mode, I can still see the when I use Javascript, it doesn't detect it, but it does detect cpp.
It works for cpp, and it seems fine, but when I use javascript same problem... type = array()... can't even print_r() it, cuz its empty.
Take a look: http://furix.net/AdvancedJavaScriptClassTutorial