Here's my first attempt at 5.0 support, with some additions to the CSS and output formatting. Not fully tested, but seems to work.

CommentFileSizeAuthor
#3 geshifilter.module.txt20.11 KBexecutex
#2 changeswithwhitespace.patch44.08 KBmhutch
#1 geshifilter.info_.txt129 bytesmhutch
changes.patch12.36 KBmhutch

Comments

mhutch’s picture

mhutch commented
StatusFileSize
new geshifilter.info_.txt129 bytes

And the .info file -- for some reason couldn't add it to anon CVS for adding to the patch.

mhutch’s picture

mhutch commented
StatusFileSize
new changeswithwhitespace.patch44.08 KB

And here's a version of the patch with whitespace changes of tabs to two spaces, as per Drupal guidelines.

executex’s picture

executex commented
StatusFileSize
new geshifilter.module.txt20.11 KB

There is a problem with the $types variable. In debug mode, $types[] array is empty every time, even though the settings are set. There doesn't seem to be anything wrong with the code, unless $format messed up a lot. In other words, the filter either highlights with default lang, or just a plain Geshi css. type=, doesn't work at all, it's detected, but $types is empty.

Could you please upload a FULLY TESTED version of the .module without the "changes" crap, because it really isn't working with different languages.

mhutch’s picture

mhutch commented

That's weird; it works absolutely fine for me. Have you enabled the languages you need in the filter's "configure" options (admin/settings/filters//configure)?

BTW, the attachment to the original issue lacks the whitespace changes. But the "whitespace changes only affect the appearance of the module's source.

Have you tried the http://drupal.org/node/112067 version?

executex’s picture

executex commented

Well It detects the tag at some points. I think I mixed it up before which is why I thought it wasn't detecting the tag.
I was typing language="" instead of type="",
anyway, I fixed that, but now in debug mode, I can still see the when I use Javascript, it doesn't detect it, but it does detect cpp.
It works for cpp, and it seems fine, but when I use javascript same problem... type = array()... can't even print_r() it, cuz its empty.
Take a look: http://furix.net/AdvancedJavaScriptClassTutorial

executex’s picture

executex commented

And it's definitely allowed in the settings.

soxofaan’s picture

soxofaan commented
Assigned: Unassigned » soxofaan
soxofaan’s picture

soxofaan commented
Status: Needs review » Closed (fixed)

first release of the port to 5.0:
http://drupal.org/node/171767

closing this issue
new issues should now be submitted against the right version