Hi - I've been bit by the README too many times, so here's an update.

1. We really should require libraries so that glip gets put in the right place.
2. Using 1.0 of glip is a disaster, as it's missing a fundamental commit (this now recommends master)

CommentFileSizeAuthor
git_deploy.require_libraries.patch1.11 KBrfay

Comments

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Needs review » Reviewed & tested by the community

The outdated 1.0 tag of glip has bitten me too. Requiring libraries makes sense. This is good to go.

_-.’s picture

_-. commented

i've

drush core-status | egrep version
 Drupal version         :  7.4                               
 Drush version          :  5.0-dev

with

drush pm-list | grep -i git
 Other                        Git Deploy (git_deploy)                                      Module  Enabled        7.x-1.x-dev

and,

cd sites/all/libraries/glip
git log | head -n 5
  commit 79f5472af4b9261d20f51e92f07d4cca01e83a2c
  Author: Damien Tournoud <damien@commerceguys.com>
  Date:   Fri Mar 4 16:23:16 2011 -0500
  
      Implement support for alternates object stores.
  
git branch -a | grep \*
  * master

but @ .../admin/reports/status, I see

Glip Library	See the instructions in sites/all/modules/git_deploy/README.txt
The Glip library must be present to use git_deploy.

in "not a problem Green" ... which is confusing. Does git_deploy, with glip git-master installed, have what it needs?

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
commented
Status: Reviewed & tested by the community » Needs work

@x746554, that's a confusing message, but it's unrelated to this issue. I've opened up #1212942: Clean up git_deploy_requirements(), please follow up there.

In regards to this issue the patch in #0 needs work because there are several instances of if (module_exists('libraries')) which are no longer needed. It could be argued that they should be left in the D6 version given D6's broken dependency checking on module update. But in D7 if libraries is required then there's no point in checking if the module exists.

amontero’s picture

amontero
Location Barcelona
commented

As a related issue, drush make users might be interested in checking/reviewing #1649522: Add "drush make" file for automatically installing glip

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Please note that development of this module went on without glip.

I recommend to everyone to use 7.x-2.x, which does not require glip. Not sure why it's not the recommended release.

amontero’s picture

amontero
Location Barcelona
commented

I was not aware of that, Randy. Posted follow-up comment at #1649522-1: Add "drush make" file for automatically installing glip. I need some feedback about that. TIA.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Title: Require libraries module and update documentation to that effect » Fix inconsistent location of Glip library
Issue summary: View changes
Status: Needs work » Active

Glip can be installed in the libraries folder without requiring the Libraries module.

darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Related issues: +#1649522: Add "drush make" file for automatically installing glip

  • Darren Oh committed 22d6454 on 7.x-1.x 
    Issue #1203134 by Darren Oh: Fix inconsistent location of glip library
darren oh’s picture

darren oh
Primary language English
Location Lakeland, Florida
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.