Jump to:
| Project: | Skinr |
| Version: | 6.x-1.6 |
| Component: | Code |
| Category: | bug report |
| Priority: | major |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
Hello!
I've been trying to track down an issue where my panels disappear after clearing the cache. I started working through the suggestions found on this panels ticket until I discovered that the culprit was missing skinr theme functions. Based on this comment by merlinofchaos in the same thread, I created the attached patch to see if moving hook_ctools_plugin_directory() to skinr.module fixes the problem. It does fix the problem!
This means that modules/panels.skinr.inc isn't getting loaded during the theme cache rebuild sometimes.
I know my patch isn't acceptable as-is -- because it defeats the modularlarity of keeping panels support in a seperate include file. However, I couldn't find where in Skinr this file is loaded! Can you please point out where the loading takes place?
Also, I'm not entirely sure how to trigger its loading at the right time. We really can't detect when ctools is about to call hook_ctools_plugin_directory()... So, maybe we should always load it? What do you think?
At the very least, this patch will help other users experiencing this problem work around it temporarily.
Best regards,
David.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| skinr-979912.diff | 1.33 KB | Idle | FAILED: [[SimpleTest]]: [MySQL] Unable to apply patch skinr-979912.diff. Unable to apply patch. See the log in the details link for more information. | View details | Re-test |
Comments
#1
I'm a bit confused about what to do here.
@@ -402,4 +388,4 @@
/**
* @}
- */
\ No newline at end of file
+ */
Do I remove or add the last line where is says */ ?
#2
anyone? I also find that my php error logs record the following errors:
[24-Feb-2012 11:48:56] PHP Fatal error: fatal flex scanner internal error--end of buffer missed in /home3/babblefl/public_html/sites/all/modules/skinr/modules/panels.skinr.inc on line 388
[24-Feb-2012 11:48:59] PHP Warning: Unterminated comment starting line 388 in /home3/babblefl/public_html/sites/all/modules/skinr/modules/panels.skinr.inc on line 388
#3
"No newline at end of file" just means that. There was previously a line break at the end of the file, where there currently is none. Leave the "*/" on the last line.
You should read about applying patches in the drupal docs.
http://drupal.org/node/60108
#4
#5
#6
The last submitted patch, skinr-979912.diff, failed testing.
#7
This patch did not work for me. Panels is still not showing.
any updates?
moonray, there was no line break at the end of the file previously which is why I was confused.