Hello!

I've been trying to track down an issue where my panels disappear after clearing the cache. I started working through the suggestions found on this panels ticket until I discovered that the culprit was missing skinr theme functions. Based on this comment by merlinofchaos in the same thread, I created the attached patch to see if moving hook_ctools_plugin_directory() to skinr.module fixes the problem. It does fix the problem!

This means that modules/panels.skinr.inc isn't getting loaded during the theme cache rebuild sometimes.

I know my patch isn't acceptable as-is -- because it defeats the modularlarity of keeping panels support in a seperate include file. However, I couldn't find where in Skinr this file is loaded! Can you please point out where the loading takes place?

Also, I'm not entirely sure how to trigger its loading at the right time. We really can't detect when ctools is about to call hook_ctools_plugin_directory()... So, maybe we should always load it? What do you think?

At the very least, this patch will help other users experiencing this problem work around it temporarily.

Best regards,
David.

CommentFileSizeAuthor
skinr-979912.diff1.33 KBdsnopek

Comments

yosisays’s picture

yosisays commented

I'm a bit confused about what to do here.

@@ -402,4 +388,4 @@
 
 /**
  * @}
- */
\ No newline at end of file
+ */

Do I remove or add the last line where is says */ ?

yosisays’s picture

yosisays commented

anyone? I also find that my php error logs record the following errors:

[24-Feb-2012 11:48:56] PHP Fatal error: fatal flex scanner internal error--end of buffer missed in /home3/babblefl/public_html/sites/all/modules/skinr/modules/panels.skinr.inc on line 388

[24-Feb-2012 11:48:59] PHP Warning: Unterminated comment starting line 388 in /home3/babblefl/public_html/sites/all/modules/skinr/modules/panels.skinr.inc on line 388

moonray’s picture

moonray commented

"No newline at end of file" just means that. There was previously a line break at the end of the file, where there currently is none. Leave the "*/" on the last line.

You should read about applying patches in the drupal docs.
http://drupal.org/node/60108

moonray’s picture

moonray commented
Status: Active » Fixed
moonray’s picture

moonray commented
Status: Fixed » Needs review

Status: Needs review » Needs work

The last submitted patch, skinr-979912.diff, failed testing.

yosisays’s picture

yosisays commented

This patch did not work for me. Panels is still not showing.

any updates?

moonray, there was no line break at the end of the file previously which is why I was confused.

jvieille’s picture

jvieille commented

This patch solved my problem
http://drupal.org/node/979912#comment-6390122

Can the skinr team consider this bug and commit this?
Only the patch is malformed, but it should be easy to fix

Thanks!

yosisays’s picture

yosisays commented

You realize that your link is a goose chase back to this thread? It brings me to your post #168 in issue #979912 where you provide a link that brings me to comment # 102 of that same thread/issue which provides a link back to this thread! What patch are you referring to?
either way, this patch did not work for me. any updates on this?

jvieille’s picture

jvieille commented

Well, I realize your trouble following the links I submitted...
There is a logic though, but it would be long to explain and worthless..

So instead, I will just affirm that the patch submitted in the head of this issue is the one that worked for me.
Sorry for the mess...

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

@jvieille, if it works for you, could you mark it as "reviewed & tested by the community"? This will hopefully help us in convincing the skinr upstream maintainers to accept this patch. :-)

jvieille’s picture

jvieille commented
Status: Needs work » Reviewed & tested by the community

Right!
A zero fault patch submitted 16 months ago really reserves to be committed.

moonray’s picture

moonray commented
Version: 6.x-1.6 » 6.x-1.x-dev
Issue summary: View changes
astonvictor’s picture

astonvictor commented
Status: Reviewed & tested by the community » Closed (outdated)

D6 reached its EOL back in February 2016, and there is no active release for D6 for this module anymore.
Development or support is not planned for D6. All D6-related issues are marked as outdated in a bunch.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.