Let's say I wanted to have a view of content exposed to the front page. This view is first sorted by stickyness and then by publish date (descending). If I expose only the publish date sort then views produces a query that sorts by publish date and then by stickyness (in general: exposed sorts are put before other non-exposed sorts - ignoring sort weight).
I think this is counterintuitive. The provided patch fixes this.

CommentFileSizeAuthor
#11 Views-Exposed_sorts_override_sorts_weight-1203794-11.patch1.39 KBtimmerk
#7 Exposed-sorts-override-sorts-weight--1203794--7.patch1.85 KBparanojik
exposed-sorts-ignore-sorts-weight.patch1.39 KBparanojik

Comments

slashrsm’s picture

slashrsm commented

I agree. Interested in this beeing commited.

p4trizio’s picture

p4trizio commented

I agree too

slashrsm’s picture

slashrsm commented
Status: Needs review » Reviewed & tested by the community
dawehner’s picture

dawehner
Primary language German
commented

@slashrsm

Could you please write at least some words why you made this RTBC?

In general the code change make sense, but perhaps some inline comment would be cool to not make the same mistake again. A simpletest would be the best thing, but noone writes them.

slashrsm’s picture

slashrsm commented

Sorry.... I already reviewed this in #1. Since p4trizio agreed with me in #2 I changed status to RTBC.

p4trizio’s picture

p4trizio commented

It works in the way I expected :-)

Thanks

paranojik’s picture

paranojik commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new Exposed-sorts-override-sorts-weight--1203794--7.patch1.85 KB

Added comment and reapplied. I'll see if I can manage to also write a test.

slashrsm’s picture

slashrsm commented

This looks ok.

dawehner’s picture

dawehner
Primary language German
commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

Patch looks really fine, so commited to 7.x-3.x.

This seems to be worth to be added to 6.x-3.x as well.

timmerk’s picture

timmerk commented

Thanks for the patch! I'll post an updated patch for the latest dev code tomorrow.

timmerk’s picture

timmerk commented
StatusFileSize
new Views-Exposed_sorts_override_sorts_weight-1203794-11.patch1.39 KB

Here's a patch for the latest 6.x-3.x code.

chris matthews’s picture

chris matthews commented
Issue summary: View changes
Status: Patch (to be ported) » Closed (outdated)

The Drupal 6 branch is no longer supported, please check with the D6LTS project if you need further support. For more information as to why this issue was closed, please see issue #3030347: Plan to clean process issue queue