Closed (won't fix)
Project:
Documentation
Component:
Correction/Clarification
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
29 Jun 2011 at 14:56 UTC
Updated:
6 Jul 2011 at 16:55 UTC
Running "git blame" over core says that webchick and Dries are responsible for nearly every line. This is not true.
If we started making patches with "git format-patch" rather than "git diff" then proper attribution could be made.
As a start, the patch guidelines should recommend "git format-patch" rather than "git diff" somewhere more prominent than the current mention buried halfway down the Advanced patch contributor guide.
Comments
Comment #1
jhodgdonMoving to correct issue queue for this discussion
Comment #2
eliza411 commentedConversations about how to handle attribution and patching happen frequently, and the latest is still taking place at http://groups.drupal.org/node/148184.
Where Git is concerned, we've been trying to keep the discussions that change the entire way the community does business over on g.d.o. until some kind of actionable decision is reached, at which point it would become appropriate to open a Docs issue.
This is no judgment of the content of this issue ... just trying to keep all the folks interested in the topic talking in a somewhat central place, and the I think the outcome of the Drupal 8 initiatives discussion about Working with Git seems most likely to set the recommendation for some to come.
Comment #3
pillarsdotnet commentedYou referred me to an "invite-only" group in which I am forbidden to participate, or even apply for membership.
I'm sure you didn't mean it that way, but the impression this gives is that the elite members of the Drupal community don't want to hear what anybody else has to say on this topic.
Comment #4
eliza411 commentedIt really does give the impression, doesn't it? You are correct that it is not what I meant, and I appreciate the benefit of the doubt. I apologize for doing that. I honestly forgot that the group was invite-only and I wasn't giving my best attention to what I was doing.
Let me try this another way for now ... I will cross-post this issue in that invite-only group so that participants discussing the related issue there will be aware of what you and anyone else who responds to this issue is saying.
I *still* believe this decision (and ones like it, affecting the way the community operates) should be reaching a wider audience than an issue queue so that there's a higher chance of reaching the best possible outcome and we as a community aren't switching our best practice recommendations back and forth every couple of months.
I confess to being sensitive on this topic. During the Git migration there were many lengthy discussions about this exact subject in an effort to make the best decision possible, and the Git team went forward with what you're recommending above only to have all of the documentation revised without any community conversation. Much more discussion followed after that happened and the outcome was the process recommended in the documentation that you see today.
Comment #5
jhodgdonI believe that anyone can *comment* on nodes in the invitation-only group, right? So it is probably fine to close this issue after all and have the discussion about what to do for formatting patches there.
Comment #6
eliza411 commentedYes, it does appear anyone can comment in that discussion, and it will be a broader audience, so I'm closing this as won't fix. If a decision is made to change the community workflow, then we can re-open appropriate docs issues.