In my setup, alpha pager throws out the error message: Alpha Pager called with no defined query on top, and items are displayed in a standard (numerically paged) way.

It seems to me that queries are not initialized properly, so here is my proposed patch (well, the first "correction" was introduced by a coincidence and is absolutely unnecessary, but I was too lazy to remove it; in any case, blank spaces are not necessary in empty lines all over...):

--- views_alpha_pager.module.ORIG	2007-02-16 14:04:14.000000000 +0100
+++ views_alpha_pager.module	2007-02-18 23:32:18.000000000 +0100
@@ -138,13 +138,21 @@
   }
   $view->query = str_replace_first(" ORDER BY ", " ORDER BY $myfield, ", $view->query);
   $view->countquery = str_replace_first(" ORDER BY ", " ORDER BY $myfield, ", $view->countquery);
-  
+
   // save the pager so we can add it to the top and bottom easily
   $view->alpha_pager_output = theme("alpha_pager", $items, $apage);
 }
 
 function _views_alpha_pager_build_query($view) {
+
+  $views_path = drupal_get_path('module', 'views');
+  require_once("./$views_path/views_query.inc");
+  $info = _views_build_query($view);
+  $view->query = _views_replace_args($info['query'], $info['args']);
+  $view->countquery = _views_replace_args($info['countquery'], $info['args']);
+
   $query = $view->query;
+  $countquery = $view->countquery;
 
   // Run-time replacement so we can do cacheing
   $replacements = module_invoke_all('views_query_substitutions', $view);

This patch resolved all issues on my test page (2 items per page, 1 sort criteria field = node title) and items are displayed perfectly, 2 by 2, also with numeric paging if needed (if there are more than 2 item per letter; by the way, it would be nice to set also a demonstration site thsi way, to show some pages also with numeric pagination, or?), but probably more testing wouldn't hurt before announcing it as a solution.

Comments

douggreen’s picture

douggreen commented
Priority: Critical » Normal

Thanks for the code! I need help confirming that it is needed. I was previously able to reproduce the problem in D4.7, but I'm not longer able to reproduce it in D5.

Please make sure that your version of views.module is at least 1.166.2.6 (which is what I have installed).

If your version of views is at or higher than this, then please provide the "export" code for you view so that I can import and test it on my system.

luti’s picture

luti commented

I have exactly the same version of views module.

Export is:

 $view = new stdClass();
  $view->name = 'test';
  $view->description = 'Test Views Page';
  $view->access = array (
  0 => '3',
  1 => '1',
  2 => '2',
  3 => '5',
  4 => '6',
  5 => '7',
);
  $view->view_args_php = '';
  $view->page = TRUE;
  $view->page_title = 'Test View';
  $view->page_header = '';
  $view->page_header_format = '1';
  $view->page_footer = '';
  $view->page_footer_format = '1';
  $view->page_empty = 'Empty page';
  $view->page_empty_format = '1';
  $view->page_type = 'table';
  $view->url = 'test_view';
  $view->use_pager = TRUE;
  $view->nodes_per_page = '2';
  $view->sort = array (
    array (
      'tablename' => 'node',
      'field' => 'title',
      'sortorder' => 'ASC',
      'options' => '',
    ),
  );
  $view->argument = array (
  );
  $view->field = array (
    array (
      'tablename' => 'node',
      'field' => 'title',
      'label' => 'Title:',
      'handler' => 'views_handler_field_nodelink_with_mark',
      'sortable' => '1',
      'defaultsort' => 'ASC',
      'options' => 'link',
    ),
    array (
      'tablename' => 'node',
      'field' => 'body',
      'label' => 'Body:',
      'handler' => 'views_handler_field_teaser',
    ),
  );
  $view->filter = array (
    array (
      'tablename' => 'term_node',
      'field' => 'tid',
      'operator' => 'OR',
      'options' => '',
      'value' => array (
  0 => '3',
),
    ),
  );
  $view->exposed_filter = array (
  );
  $view->requires = array(node, term_node);
  $views[$view->name] = $view;
douggreen’s picture

douggreen commented
Status: Needs review » Fixed

I was able to reproduce and fix the problem. Thanks!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)