File deleted when submitting after saving as draft

For the clarity of my understanding of the problem, are you saying that after a user has browsed to the file to upload, and then clicks on Save as Draft that this causes the 'browsed to' filename to disappear from the file field? If so, then this possibly more of an HTTP limitation than a Webform issue as such.

Whoops, I get a similar result when there's a validation error on the page as well (i.e. file browsing text disappears).

I agree, there must be some elegantly simple and monumentally effective way of dealing with this, but it falls well within my ignorance zone at this time. I'll see if I can dig up anything useful and post back here in a day or few.

Regarding the file being lost on a validation error, that's a separate issue over here: #322786: File attachment lost after validation error

Webform already has the ability to save a file via a hidden field and show the file name below the upload field in the event that you are viewing, editing, or resuming an existing submission. I'm guessing there's a bug in our handling of drafts that prevents this from working correctly.

I've added a patch to my version (6.x-3.11) that seems to solve the problem. In components/file.inc at line 504, I changed this code:

    // Delete any previous files.
    if ($value['_old'] && ($existing = webform_get_file($value['_old']))) {
      file_delete($existing->filepath);
      db_query("DELETE FROM {files} WHERE fid = %d", $existing->fid);
    }

to this (don't delete the file if _old == _fid):

    // Delete any previous files.
    if ($value['_old'] && $value['_old'] != $value['_fid'] && ($existing = webform_get_file($value['_old']))) {
      file_delete($existing->filepath);
      db_query("DELETE FROM {files} WHERE fid = %d", $existing->fid);
    }

Ooo, nice one. Looks like it could work to me. I'll need to test this out to make sure there isn't some other code that should be solving this problem, but that change looks like a nice safety-catch in any case.

I could be getting this one as well.

I've tested this patch out in both Drupal 6 and Drupal 7 (which both had the problem) and it corrects both of them. Thanks mjwright! I've made it into a patch (attached here) and committed it to both branches of the Webform project.

I getting this same issue on 6x-3.14, attaching a file but losing it when save draft is used. What's weirder is the link to the file is showing up in the email but leads to a page not found and the file is not found in the database or results.

I am finding that files are saved the first time you 'Save Draft' but are lost if you 'Save Draft' a second time without re-uploading.

Sorry this fix was *not* in 3.12 or 3.13. I even committed my changes before 3.13 was released, but the 3.13 release wasn't made off of the "master" or 6.x-3.x branch, so the change wasn't included. This will be in the 3.15 versions for both D6 and D7.

Attached is a GitX screenshot of the changelog so you can see how this happened.