Duplicate entry error when title is empty

cleaning up queue

If you check the dev branch, there are already issets wrapped around the insert and update hooks that solve this problem. If you'd like to add a delete when title is empty though, I'll review that patch :)

Ah yea, those lines are probably the result of my overachieving IDE. The produced was:

user warning: Duplicate entry '2' for key 'PRIMARY' query: INSERT INTO taxonomy_title (tid, title) VALUES (2, '') in taxonomy_title.module on line 161.

This error occurred in the event that you edit a term with an empty title. The empty titles were caused by checking if a $form_state value was set, which it always is due to the form API. The update function checks against existence of a record which exists with an empty title string, but the check fails because an empty string is also false (go PHP freetyping ;). Thus causing the insert error.

I uploaded a new patch, with only the necessary lines. It also includes a ‘no query’ check by submitting an arbitrary flag that signals if there was a previous taxonomy title.

Great work :)

I've cleaned up some of your syntax: changed true to TRUE and added/removed some spaces where necessary. See http://drupal.org/coding-standards for reference. Here's a new patch. Can you test this one and make sure it works the same as yours?

Thanks for the cleanup, I will have to outfit a formatter to match those coding standards and try out those development modules.

All mutations on terms and titles are working like in my patch. This works.

Thanks! (In the future, you can also change the status of the issue when you leave your comment)

Do you feel up to providing a matching patch for the D7 branch? :)

committed to 6.x-1.x . will be included in the next release.

Then I am now officialy a Drupal contributor. :)

*Pops the cork*

Congratulations, and thank you! :)