The attached patch makes analyze check for broken plugins and handlers and calls validate.

CommentFileSizeAuthor
#3 1205626-3.views-convert-partial.d6.patch719 bytesdww
#2 1205626_d7_untested.patch4.78 KBchx
views_analyze.patch4.04 KBchx

Comments

dawehner’s picture

dawehner
Primary language German
commented
Version: 6.x-3.x-dev » 7.x-3.x-dev
Assigned: chx » Unassigned
Status: Needs review » Patch (to be ported)

Manual testing worked fine by changing a field to a invalid one.
Thanks for the patch!

Commited to 6.x-3.x but sadly this change needs a rerole.

chx’s picture

chx commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 1205626_d7_untested.patch4.78 KB

Reroll.

dww’s picture

dww
we/he/they
commented
StatusFileSize
new 1205626-3.views-convert-partial.d6.patch719 bytes

Here's a patch for D6 that still lets you import V1 views that have analysis errors. IMHO, better to let views do 95% of the work and you have to manually fix the last 5% than to force you to do 100% of the work yourself just because 5% is broken. Now, instead of a fatal error to import/convert, we just print the validation errors when we land on the view edit screen.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Needs work

Got sign-off from merlinofchaos, dereine and chx in IRC, so I committed/pushed #3 to 6.x-3.x. #2 needs to be re-rolled accordingly.