sf-import drush command doesn't like a map with the field 'Id' in it [#1205650]

I have mapped the Salesforce field 'Id' into my Drupal node because I use it for various things. However, sf_import.drush.inc about line 236 hardcodes the file 'Id' into an SOQL select query.

Here is what I am running and what I get.

drush sf-import 3124860e3cb9faa393e014471460eced --count 1
drush: Error while querying Salesforce : INVALID_FIELD:
Description, Donation_Record_ID__c, Id, OwnerId, Response_Code__c, Type
                                    ^
ERROR at Row:2:Column:128
duplicate field selected: Id
Drush command terminated abnormally due to an unrecoverable error.                                                                                                                  [error]

Comment	File	Size	Author
#5	sf_import.drush_.inc_.patch	832 bytes	Alice Heaton
#3	sf_import.drush_.inc_.patch	746 bytes	Alice Heaton
#1	1205650-drush_sf_import_id_field-1.patch	869 bytes	dpearcefl

Comments

Comment #1

dpearcefl commented 30 June 2011 at 21:38

Status:

Active

» Needs review

Status	File	Size
new	1205650-drush_sf_import_id_field-1.patch	869 bytes

Also found another curious bug for nodes.

Patch attached.

Comment #2

EvanDonovan commented 2 July 2011 at 17:22

Issue tags:

+7.x-2.x

Tracking for 7.x-2.x.

Comment #3

Alice Heaton commented 9 November 2011 at 12:51

Priority:	Normal	» Major
Status:	Needs review	» Reviewed & tested by the community

Status	File	Size
new	sf_import.drush_.inc_.patch	746 bytes

Hi,

The patch given by @dpearceMN fixes two issues :

drush sf-import does not work if Id field is included in query ;
drush sf-import does not work for nodes.

I have made the following modifications to the original patch :

cosmetic change ; use in_array rather than array_search
to be consistent with the rest of the code in the file ;
Use '===' operator when checking for return value
of strpos, as this may return FALSE. (because of this, the original
patch would not have worked for non-node types. It now
covers both cases).

The patch works for me. I'm setting this to 'major', because the drush sf-import command
is not working at the moment for node types at all.