Steps to reproduce:
/**
* Implements hook_system_info_alter().
*/
function standard_system_info_alter(&$info, $file, $type) {
if ($file->name == 'field_sql_storage') {
$info['hidden'] = TRUE;
}
}
This bug affects e.g. Drupal distributions which might want to hide certain core required modules from appearing on the modules page in order to simplify it.
I'm attaching two patches, one which I think is correct and one which I almost thought was correct until I realized it causes a regression in certain edge cases. This patch will need tests either way, but I'm uploading both to see exactly what kinds of tests it will need; I'm hoping the second patch will fail existing tests, but I have a feeling it won't :)
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | hidden-required-modules-1205684-15.patch | 4 KB | lliss |
| #13 | hidden-required-modules-1205684-13.patch | 0 bytes | lliss |
| #10 | hidden-required-modules-1205684-10.patch | 2.99 KB | lliss |
| #7 | 1205684-7.patch | 1.01 KB | star-szr |
| #7 | 1205684-7-WRONG-FIX.patch | 884 bytes | star-szr |
Comments
Comment #1
David_Rothstein commentedThe first patch had a typo in the code comment - reuploading.
Comment #3
David_Rothstein commented#1: hidden-required-modules-WRONG-FIX.patch queued for re-testing.
Comment #4
m1n0 commented#1: hidden-required-modules-WRONG-FIX.patch queued for re-testing.
Comment #5
m1n0 commented#1: hidden-required-modules.patch queued for re-testing.
Comment #7
star-szrRerolled against 8.x HEAD at the London Ontario Drupal Users Group.
Comment #9
lliss commentedThis is a tricky one test test I think. We want a test module that relies on a hidden module and shows up on the modules page for testing. But we don't want this to show up normally. My approach was to make a test module that relies on another test module and then have the first module override the info of the second so that it sets it to hidden = FALSE. Then we just need to have the test enable the first module and try to enable the second module through the interface. So far this hasn't gone well in my experiments as I am not successfully able to override the hidden property.
Comment #10
lliss commentedThis is a decent start for the test but needs some work still.
Comment #11
star-szrThanks @lliss, that definitely looks like a good start!
Setting to needs review so testbot can run it. Can you please upload a patch combining the test along with the first patch in #7? See #13 in http://drupal.org/node/1468170.
Comment #13
lliss commentedTest and patch from #7 rolled into one.
Comment #14
lliss commentedComment #15
lliss commentedDoh. It helps to have something in the file.
Comment #17
heddnA lot has changed since 2012, please confirm this is still an issue.
Comment #26
quietone commentedAs said in #17 a lot has changed.
Can anyone confirm that this is still a problem?
Comment #27
pameeela commentedI remember this in D7 (pretty sure it occurred in aGov/GovCMS) but have never seen it in 8/9, even though there are enabled hidden modules, so I think it can be closed. Not sure how to completely confirm it though.
Comment #28
longwaveI added this to system_system_info_alter:
The modules list page now hides the System module, and submitting the form works as expected and produces no errors.
Closing this as outdated as there is nothing to do here.