If there are no alias created by pathauto globalredirect works fine. However, if there are aliases created by pathauto then globalredirect creates bad canonical with duplicated language argument.

The correct canonical would be something like this:
link href="http://www.example.com/pt-br/node_title" rel="canonical"
The bad canonicals has duplicated language argument (/pt-br/pt-br/):
link href="http://www.example.com/pt-br/pt-br/node_title" rel="canonical"

I tested on pathauto-7.x-1.0-rc2

CommentFileSizeAuthor
#14 1205982-14-remove-canonical.patch1.22 KBmoymilo
#9 1205982-caninical.patch1.3 KBRavindraSingh
#9 canonical-twice-time.png57.32 KBRavindraSingh
#3 1205982-globalredirect-duplicate-canonical-prefix.patch585 bytesmrfelton

Comments

mac_weber’s picture

mac_weber commented
Priority: Normal » Major

changing to major because of SEO problems this issue can bring

mac_weber’s picture

mac_weber commented

I changed line 241 from:

'href' => url(drupal_is_front_page() ? '<front>' : $request_path, array('absolute' => TRUE, 'query' => $query_string)),

to:

 'href' => url(drupal_is_front_page() ? '<front>' : substr($request_path, strlen($prefix)), array('absolute' => TRUE, 'query' => $query_string)),

Canonicals look good now, yet this is far from the best solution. I'm not sure if the problem is on $prefix or 'prefix' on the options array of url()

mrfelton’s picture

mrfelton commented
StatusFileSize
new 1205982-globalredirect-duplicate-canonical-prefix.patch585 bytes

Attached patch basically does what was suggested in #2, which seems to work. (This patch is for D6)

mrfelton’s picture

mrfelton commented
Status: Active » Needs review
mac_weber’s picture

mac_weber commented

mrfelton, this does not really fix the problem.

It just make masquerades the problem. Again, it should be fixed on $prefix or 'prefix' (I don't know exactly which one).

mrfelton’s picture

mrfelton commented

Yes Mac, please see #1208144: in case of fallback language canonical should point to original language. This issue is tied up with that one, and there is a more complete patch in that ticket.

marcoka’s picture

marcoka commented

i can 100% confirm the issue i get the language prefix twice to, like de/de or en/en
It also seems that the metatags module already adds one correctly

...

...

Status: Needs review » Needs work

The last submitted patch, 1205982-globalredirect-duplicate-canonical-prefix.patch, failed testing.

RavindraSingh’s picture

RavindraSingh commented
Issue summary: View changes
StatusFileSize
new canonical-twice-time.png57.32 KB
new 1205982-caninical.patch1.3 KB

Drupal core provides default canonical URLs for nodes pages, If you have enabled the global redirect for multilingual site you would see this error definitely, even you would see canonical is placed twice in node page.

Canonical URL issue

And I think everysite needs it for SEO. where site owner definitely add meta tags module.
So this would be the good idea to remove canonical code from global redirect module. So I have created a patch for that.

RavindraSingh’s picture

RavindraSingh commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 9: 1205982-caninical.patch, failed testing.

Status: Needs work » Needs review

RavindraSingh queued 9: 1205982-caninical.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 9: 1205982-caninical.patch, failed testing. View results

moymilo’s picture

moymilo commented
Status: Needs work » Needs review
StatusFileSize
new 1205982-14-remove-canonical.patch1.22 KB

Re-apply patch on the new code base.

moymilo’s picture

moymilo commented