Case is following http://drupal.org/node/1204200

advupload need menu_rebuild after changing it's settings.
add menu_rebuild into advimage_up.install in advimage_up_install() hook

Comments

ailgm’s picture

I'm not sure the menu is the cause of the problem. I do have a menu item now for "Create node or nodes via bulk upload", going to /advupload. On that page is a link to "Bulk upload files for node type 'Image gallery entry - single image' (For each file add it's new node)", going to /advupload/advimage_multinode. Following that link leads to a "Page not found" error.

ilya1st’s picture

All is based on internal drupal menu system. see hook_menu() on api.drupal.org.
All you need now - go to /admin/settings/advupload and just make saving of all again.

/advupload and all derived paths you can add to your drupal menus manually. we do that so.

ailgm’s picture

I did go to the settings and save it again. It made no difference.

I'm not sure why you're referring to the menu. I don't think that's the problem.

It's that the secondary link to the /advupload/advimage_multinode page fails, returning a "Page not found" error. How is this page supposed to get created? Is there code building it somewhere?

ilya1st’s picture

Status: Active » Closed (cannot reproduce)

It's that the secondary link to the /advupload/advimage_multinode page fails, returning a "Page not found" error. How is this page supposed to get created? Is there code building it somewhere?

see main advupload module advupload.module file in the advupload_menu() hook all is built there by system variables settings.
Drupal caches menu. So we need menu_rebuild() call when change variables.

added fix in -dev.

I recommend to dance around advupload.module file to see how menu work there

ailgm’s picture

Status: Closed (cannot reproduce) » Active

I had a developer look into this further, and he found that the problem was somehow related to having the xml_sitemap_node module also enabled. Could you check into this conflict?

ilya1st’s picture

Status: Active » Closed (won't fix)

there are used standard drupal hooks.

Sorry but I'm not interested in doing your local job only because you do not have real normal programmer.

ailgm’s picture

Your module conflicts with another. Instead of insulting us, you could be pleased that someone else took the time to test and identify an issue. We won't be the only ones who run into this.

ilya1st’s picture

Your module conflicts with another. Instead of insulting us, you could be pleased that someone else took the time to test and identify an issue. We won't be the only ones who run into this.

Ok. Even if it conflicts with some another module please show me point of this conflict with parts of PHP code which cause this conflict in BOTH MODULES.

I have no time/money doing your job for free only because of you or your "experienced developer" cannot do that.

ailgm’s picture

Status: Closed (won't fix) » Needs review

The corrections required are to initialize $form_state as an array:

1) in advimage_up.module, before calling drupal_prepare_form, add this line (e.g at line 13):
$form_state = array();

2) in advimage_og.handlers.inc (in function advimage_og_prepare_node_fieldset), before calling _advimage_og_form_add_og_audience, add this line (e.g. at line 96):
$form_state = array();

It's a nice module you've shared. However most module maintainers are grateful for issues being reported and take an interest in finding the cause (after all, they know the code better than anyone and by sharing their module presumably intend to be helpful to others). If you want people to use it, the negative attitude shown by some of your comments will not help -- they come across as insulting and not in the spirit of the Drupal community.

ilya1st’s picture

will fix in -dev now.
I'm grateful for yous issues. But I hope you understand I have no time for full debug of module set and best way is to give more information.
And this is not error in this case. Array but was not initialized but there is a lot of such code which cause PHP warnings even in D6 and even in D7 core.

Thanks a lot for helping to make code cleaner.

ilya1st’s picture

Status: Needs review » Fixed

commited to -dev.
will add some another fixes for JS(we have own issues set for CCK fields there) and then publish new release with patches.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.