Download & Extend
Page Title » Issues

Strict warning : Only variables should be passed by reference dans views_page_title_pattern_alter()

Posted by anou on July 1, 2011 at 9:48am
Project:Page Title
Version:7.x-2.5
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hello
I tried to use page_title in views (without any success for now) so I made a display in a view with the page_title option. Because I failed to make it work, I've deleted this display, and left my view has it was before my test.

Since then, when I go on pages made by views, I got this srtict warning :

Strict warning : Only variables should be passed by reference dans views_page_title_pattern_alter()(line 33 in /sites/all/modules/page_title/modules/views.page_title.inc).

Anyone has an idea from where it can come from ?
Maybe must I delete something in the DB ?

Thanks for your help.

Login or register to post comments

Comments

#1

Posted by nicholasThompson on July 1, 2011 at 10:22am

I wonder what's being passed into that function which isn't a variable?!

#2

Posted by anou on July 1, 2011 at 12:21pm

Is that suppose to mean that I can't pass some fixed string, must only use the tokens ?
...

#3

Posted by nicholasThompson on July 1, 2011 at 12:28pm

You cant alter a fixed string - however you can alter a string assigned to a variable... eg:

Bad:

<?php
thingy('test');

function thingy(&$var) {
  $var = 'another test';
}
?>

Good

<?php
$a = 'test';
thingy($a);

function thingy(&$var) {
  $var = 'another test';
}
?>

#4

Posted by Marshall_Kennard on August 15, 2011 at 6:54pm

To fix the original problem in views.page_title.inc, replace line 33 with this:

// $h = array_shift(array_splice($h, count($args)-1, 1));
$hh = array_splice($h, count($args)-1, 1);
$h = array_shift($hh);

#5

Posted by awm086 on September 9, 2011 at 7:44pm

subscribe

#6

Posted by wusel on October 15, 2011 at 4:22pm

I get the following error-message:

Strict warning: Only variables should be passed by reference in views_page_title_pattern_alter() (line 33 of C:\xampplite\htdocs\abt\sites\all\modules\page_title\modules\views.page_title.inc).

Please help me.
Thanks in advance

#7

Posted by Lostmonkey on January 9, 2012 at 11:58pm

I get the exact same error-message (#6), did you solve it?

#8

Posted by a.milkovsky on January 13, 2012 at 4:10pm

Marshall_Kennard , thanks

#9

Posted by Lios on January 24, 2012 at 2:57pm

That is the same message as the original post and the solution is in post #4...

#10

Posted by peximo on February 16, 2012 at 12:58pm
Status:active» needs review

Attached patch from comment #4

AttachmentSize
page_title-array_shift-1206164-4.patch 0 bytes

#11

Posted by peximo on February 16, 2012 at 1:02pm

Sorry empty patch; this should be right.

AttachmentSize
page_title-array_shift-1206164-4.patch 682 bytes

#12

Posted by plach on February 16, 2012 at 1:03pm
Status:needs review» reviewed & tested by the community

Looks good and works as advertised.

#13

Posted by IckZ on April 8, 2012 at 5:55pm

works! thanks for sharing :)

#14

Posted by dercheffe on May 6, 2012 at 3:29pm

An update of the module which includes this patch would be great :)

#15

Posted by nicholasThompson on May 8, 2012 at 10:39am
Status:reviewed & tested by the community» fixed

This is fixed and committed into Dev branches for D6 and D7. Tagged release soon!

#16

Posted by System Message on May 22, 2012 at 10:40am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.