When issuing drush make-generate without filename it exits rude

WD php: Warning: Missing argument 1 for drush_drush_make_make_generate() in drush_drush_make_make_generate() (line 408 of ..../.drush/drush_make/drush_make.drush.inc). [warning] 
...
WD php: Warning: file_put_contents(): Filename cannot be empty in _drush_make_generate() (line 109 of .../.drush/drush_make/drush_make.generate.inc). [warning]
Unable to write .make file <em class="placeholder"></em> [error]
Missing argument 1 for drush_drush_make_make_generate() in drush_drush_make_make_generate() (line 408 of .../.drush/drush_make/drush_make.drush.inc). [warning]
Deprecated function: Function split() is deprecated in _drush_make_generate() (line 18 of .../.drush/drush_make/drush_make.generate.inc). [error]
Deprecated function: Function split() is deprecated in _drush_make_generate() (line 18 of .../.drush/drush_make/drush_make.generate.inc). [error]
file_put_contents(): Filename cannot be empty in _drush_make_generate() (line 109 of .../.drush/drush_make/drush_make.generate.inc). [warning]
CommentFileSizeAuthor
#1 nicer-generate-1206286-1.patch1.04 KBclemens.tolboom

Comments

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new nicer-generate-1206286-1.patch1.04 KB

Patch prevent scanning for project versions by bailing out early when missing $file

dmitrig01’s picture

dmitrig01 commented
Status: Needs review » Reviewed & tested by the community

I've committed this to 2.x, but it would be good to get this in 3.x as well, so I'm leaving this issue open until I get back to committing this to 3.x.

dmitrig01’s picture

dmitrig01 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.