Download & Extend
Ubercart Marketplace » Issues

Use access arguments in hook_menu

Posted by nohup on July 2, 2011 at 12:30am
Project:Ubercart Marketplace
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

Using array(1) as 'access arguments' for hook_menu where 'access callback' is mp_marketplace_can_view_seller and using the user object passed to mp_marketplace_can_view_seller to compare the uid instead of arg(1) will make ubercart_marketplace compatible with the me module or any other module which changes/replaces the uid in the menu.

Login or register to post comments

Comments

#1

Posted by nohup on July 2, 2011 at 12:36am
Title:User access aruments in hook_menu» Use access aruments in hook_menu

git patch against 6.x-1.x attached

AttachmentSize
ubercart_marketplace-use_access_arguments-1206928-1.patch 14.6 KB

#2

Posted by longwave on September 8, 2011 at 4:38pm
Title:Use access aruments in hook_menu» Use access arguments in hook_menu
Status:active» needs work

Your patch changes many unnecessary lines.

#3

Posted by arski on February 14, 2012 at 6:16pm
Category:task» bug report

hmm, this is something that would be extremely useful indeed.. and kind of the normal practice too, so this pretty much a bug.

Before I go ahead with cleaning up that patch though - was there any particular reason why the arguments were commented out in the first place?

nobody click here