Using array(1) as 'access arguments' for hook_menu where 'access callback' is mp_marketplace_can_view_seller and using the user object passed to mp_marketplace_can_view_seller to compare the uid instead of arg(1) will make ubercart_marketplace compatible with the me module or any other module which changes/replaces the uid in the menu.

CommentFileSizeAuthor
#5 ubercart_marketplace-access_arguments-1206928.patch1.31 KBAlex Andrascu
#1 ubercart_marketplace-use_access_arguments-1206928-1.patch14.6 KBnohup

Comments

nohup’s picture

nohup commented
Title: User access aruments in hook_menu » Use access aruments in hook_menu
StatusFileSize
new ubercart_marketplace-use_access_arguments-1206928-1.patch14.6 KB

git patch against 6.x-1.x attached

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Use access aruments in hook_menu » Use access arguments in hook_menu
Status: Active » Needs work

Your patch changes many unnecessary lines.

arski’s picture

arski commented
Category: task » bug

hmm, this is something that would be extremely useful indeed.. and kind of the normal practice too, so this pretty much a bug.

Before I go ahead with cleaning up that patch though - was there any particular reason why the arguments were commented out in the first place?

Alex Andrascu’s picture

Alex Andrascu commented

What's the plan with this ?

Alex Andrascu’s picture

Alex Andrascu commented
Status: Needs work » Needs review
StatusFileSize
new ubercart_marketplace-access_arguments-1206928.patch1.31 KB

There's a cleaned patch. Unfortunatelly is against an older dev version.