modules/field_ui/field_ui.admin.inc:781 produces the error message There was a problem creating field %label: @message., where @message placeholder can be the HTMLed message generated by inclues/database/schema.inc:629: Table %name already exists.,

That produces a stranger end result like: There was a problem creating field Field Name: Table <em>Table Name</em> already exists.. (with em tags escaped).

Maybe !message should be used instead of @message.

CommentFileSizeAuthor
#12 field-ui-1206992-12.patch2.5 KBoriol_e9g
#9 after-patch.png207.59 KBoriol_e9g
#9 before-patch.png226.03 KBoriol_e9g
#8 field-ui-message-1206992-8.patch1.24 KBoriol_e9g
#5 error-confirmat.png226.03 KBoriol_e9g

Comments

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Version: 7.4 » 8.x-dev
Issue tags: +Novice

Tagging.

dsm’s picture

dsm commented
Assigned: Unassigned » dsm
xjm’s picture

xjm
she/her
Primary language English
commented

Tracking to review a patch if one is submitted.

xjm’s picture

xjm
she/her
Primary language English
commented
Assigned: dsm » Unassigned

Moving back into the queue.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
StatusFileSize
new error-confirmat.png226.03 KB

I can confirm the error in Drupal 8.x.

Plus: We should remove the two final sentence points and the error level message! Now is in green and should be an error in red!

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Needs work » Active

There are two messages with the type message problem:

drupal_set_message(t('There was a problem creating field %label: @message.', array('%label' => $instance['label'], '@message' => $e->getMessage())));
...
drupal_set_message(t('The field %label cannot be added because it is locked.', array('%label' => $values['label'])));

Should be:

drupal_set_message(t('There was a problem creating field %label: @message.', array('%label' => $instance['label'], '@message' => $e->getMessage())), 'error');
...
drupal_set_message(t('The field %label cannot be added because it is locked.', array('%label' => $values['label'])), 'error');
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Title: Field ui error message can output escaped HTML » Field ui error message and incorrect type level
Status: Active » Needs work
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Active » Needs review
StatusFileSize
new field-ui-message-1206992-8.patch1.24 KB
oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
StatusFileSize
new before-patch.png226.03 KB
new after-patch.png207.59 KB

Screenshots attached before/after patch.

danillonunes’s picture

danillonunes commented
Status: Needs review » Reviewed & tested by the community

Seems fine for me.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Needs a re-roll for the /core change.

oriol_e9g’s picture

oriol_e9g
Primary language Catalan
Location Barcelona
commented
Status: Needs work » Needs review
StatusFileSize
new field-ui-1206992-12.patch2.5 KB

Re-rolling i have found more message level errors.

agentrickard’s picture

agentrickard
he/him
Primary language English
Location Georgia (US)
commented
Status: Needs review » Reviewed & tested by the community

Nice.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x and 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.