Closed (fixed)
Project:
External iFrame
Version:
7.x-1.0-beta5
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Jul 2011 at 03:13 UTC
Updated:
24 Apr 2012 at 18:55 UTC
You should run the Coder module on your code, as it reveals a number of problems with your module. Two specific issues are:
Menu item titles and descriptions should NOT be enclosed within t().
Remove CVS $Id$ tags.
There are many more.
Comments
Comment #1
stongo commentedAgreed. I had run coder on the D6 version of the module, but I can admit to just trying to get the D7 version released in limited time, and forgot to run it through.
Expect to see a dev release with corrected/better code, and some new features.
Comment #2
stongo commentedD7 dev release should be up standards now.
Comment #3
stongo commented