I was wanting to find out all the documentation you have for this module. I'm using it and the main /user page displays the Janrain fine, the login block displays the Janrain just fine, but everywhere else on the site doesn't include Janrain.

For example, on a blog page where it says "Login or Register to post a comment," there is no Janrain there and clicking register takes you to the standard login page with no Janrain.

I'd like to know where the documentation is for this and if there is a way to get a global Janrain implementation. Thanks.

CommentFileSizeAuthor
#20 user_register_form-1207816-20.patch1.61 KBdooug

Comments

geokat’s picture

geokat commented

There's no documentation for this module other than the project
description page, readme and help messages in the module settings
pages.

The Engage icons are on the "Login" page. Make sure you turn them on
in the Engage settings (Configuratin -> Janrain Engage ->
Authentication -> Enable Janrain Engage sign-in on login forms.

Hope this helps,
George

RKS’s picture

RKS commented

Thanks, Geo. That option has already been enabled. I'll check back through the Read Me and see if I missed some setting somewhere.

RKS’s picture

RKS commented

I still don't see any login pages and I would like to confirm we are talking about the same thing.

On the login page, there are Janrain icons. On the login block, there are Janrain icons.

What I'm looking for are Janrain icons wherever a user can login on the site. So on mine, if I'm looking at a blog entry, there will be a link below that states "Login or Register to post a comment" same thing for forums etc. However, there are no Janrain icons here. Once the user clicks one of these login or register links they are taken to a new login or user registration page with no Janrain icons.

It's as if the site has two different login pages, one displayed in the menu and block, and then a separate one for comments and forum sections. I know this isn't really the case, but even with the settings all set, there are no Janrain on all pages.

Ideally, what I'm trying to achieve is to display Janrain in the options for "Login or Register to post a comment."

geokat’s picture

geokat commented

No, the module does not have the option of displaying the icons next to "Login or Register to post a comment". However, once you press the "Login" link in that call to action, the icons should be on the page which opens up.

RKS’s picture

RKS commented

Ok, I see what I'm doing wrong now. I'm actually saying one thing but meaning another.

The Janrain icons appear on the Login forms, but they do not appear on the register forms. Isn't this supposed to be the purpose of this module?

Hopefully I'm explaining myself right this time because I don't know any reason why someone who has registered would be interested in then creating a second account by using the Janrain login. I certainly don't want them creating an additional account. As it stands, I don't think it is intuitive for the user to automatically know that if they click login instead of register they will be able to select the Janrain options. Why would they? If I go to a new site, I'm not going to click login if I've never been there and know I've never created a login. I'm going to click register. After the user clicks register, the purpose of this module is lost.

RKS’s picture

RKS commented
Category: support » feature

As a temporary workaround I omitted all instances of the "Register" link on my site. Temporarily, this forces all users to click login, which I changed all instances to "Login/Register," and that takes them to the login page where the Janrain icons are present. In this way, I think users will end up on the login page and then know they have the Janrain options.

This works for me now, although, for other users I think the functionality of including the icons on the registration pages would greatly help this module achieve it's true purpose.

[NOTE] I've change this issue from support to feature but if I'm really missing something and this is already achievable at this time and I'm just missing this setting I'll change it back.

geokat’s picture

geokat commented
Title: Is there any documentation? » Include sign-in icons on the registration page
Version: 7.x-2.1-beta2 » 7.x-2.x-dev
BenK’s picture

BenK commented

I think this is a fairly important feature request. A bunch of other people have mentioned this to me at user group meetings and in IRC.

Basically, if a new user goes to the registration page to register for the site (without ever seeing the login page), there needs to be some way for them to create an account with social identity providers via Janrain Engage. This, of course, is great for Janrain because it is encouraging more users to sign-in using the Janrain service.

George, I think there are three approaches to this:

1. Add an checkbox setting so that the Janrain Engage buttons for each provider show up on the registration page.

2. Create a block that includes the Janrain Engage login buttons for each provider. Then, this block could be placed anywhere that a site administrator wants.

3. Actually create a simple API that allows the Janrain Engage login buttons for each provider to be called from the theme layer (or with a code snippet inserted in a block).

So at the root of the issue is just making things more flexible so that a site admin can embed the authentication widget wherever he wishes.

Thoughts, George?

--Ben

BenK’s picture

BenK commented

For option 1) in my prior comment, I took a closer look at the code and it seems fairly simple to implement.

Basically, in rpx_widgets.module, we'd just need to add the following code:

function rpx_widgets_form_user_register_form_alter(&$form, &$form_state) {
  if (variable_get('rpx_attach_register_form', 0)) {
    _rpx_user_login_form_alter($form, $form_state);
  }
}

Then, to actually create the checkbox setting for this feature, we'd need to add some code to supply the rpx_attach_register_form variable in rpx_ui.admin.inc. We could just add this:

$form[$group]['rpx_attach_register_form'] = array(
    '#type' => 'checkbox',
    '#title' => t('Enable Janrain Engage sign-in on user registration form'),
    '#default_value' => variable_get('rpx_attach_register_form', 0) ? 1 : 0,
    '#description' => t('Display provider links and icons on the user registration page.'),
  );

George, does this sound about right? Since the code is fairly trivial, is it possible to implement/commit this sooner rather than later?

Thanks,
Ben

RKS’s picture

RKS commented

If I'm understanding option 2 correctly, you want a block with the icons separate from the login block? If this is what you're saying, I'd second this option. I think it adds a way for admins to drive people to use the service and I know I would disable the standard login block and have just the Janrain block in place to entice users to use the service to log in.

I think adding more control for admins is definitely the direction I'd like to see this module move. I agree that this would be good for Janrain because I would much rather make it simple for my users to use already existing accounts so they don't have to fill out more registration pages.

I think a good idea would be not only to integrate the icons on registration pages, but also to incorporate them into the other functions of the site as well. A good example might be the forums and comments. Right now, you have "You must Login or Register to post a comment." I've done some hacking to get the link to use in that location and the user will be able to click and use Janrain on a new page, but the popup doesn't work. this isn't a major concern but I can see having the icons underneath that text snippet as a possible future for Janrain.

Again, it all goes back to making things simpler for users and getting more people using the Janrain service.

7wonders’s picture

7wonders commented

+1 on all 3 of your "options" Ben. No. 2 and 3 is similar to what is required for the sharing functions hack I made here http://drupal.org/node/1148644.

I think to start with is the registration page must have the sign in with rpx functionality. I tried your code above and all seems to work smoothly.

RKS’s picture

RKS commented

Maybe if we get this into a patch it can be tested and then George might be more open to implementing it sooner.

RKS’s picture

RKS commented

I can't seem to get your code to work, Ben. Maybe I'm missing the proper location. I added both codes to the module files at the end of the files.

I have a very small percentage of users that have used the Janrain login but I'm fairly certain this is simply because these icons do not appear on the registration.

silkogelman’s picture

silkogelman commented

To confirm: #9 works perfectly, thanks BenK.
I'd love to see this committed to the Janrain Engage module code asap.

I've made an attempt to expose the icons as a block, but did not succeed.
#1315726: Social Login icons as a Block

shyam541’s picture

shyam541 commented

Change described in #9 is it commited?

Ken Ficara’s picture

Ken Ficara commented

This still doesn't appear to be in the module, but to answer RKS in #14, you can put the function into rpx_widgets.module anywhere (the end of the file is a good place) but in rpx_ui.admin.inc, put the new addition to the $form array along with all the others at the beginning of the rpx_admin_settings function.

subu.purohit’s picture

subu.purohit commented

Thanks very much Ben. It is working smoothly. I have to just change the function 

function rpx_widgets_form_user_register_form_alter(&$form, &$form_state) {
  if (variable_get('rpx_attach_register_form', 0)) {
    _rpx_user_login_form_alter($form, $form_state);
  }
}

to 

function rpx_widgets_form_alter(&$form, &$form_state, $form_id) {
  if($form_id == "user_register"){
  if (variable_get('rpx_attach_register_form', 0)) {
    _rpx_user_login_form_alter($form, $form_state);
  }
  }
}
dooug’s picture

dooug commented
Component: Documentation » Code
Status: Active » Needs review
StatusFileSize
new user_register_form-1207816-20.patch1.61 KB

I rolled the code additions mentioned above into a patch against rpx 7.x-2.x-dev.

I did notice when used in conjunction with mollom, the "Sign in using on of these accounts:" awkwardly appears above the mollom input fields. Might need to adjust the weight to show below everything? This may vary with individual use.

Please test & review