Closed (won't fix)
Project:
Nodequeue
Version:
7.x-2.x-dev
Component:
Smartqueue Taxonomy
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
4 Jul 2011 at 13:45 UTC
Updated:
15 Aug 2015 at 10:20 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
amateescu commentedThe patch looks very good, but I think we need an update function to converting existing queues..
Comment #2
paranojik commentedAdded the update function.
Comment #3
paranojik commentedAnyone care to review?
Comment #4
amateescu commentedTested the patch and it works great.
Commited to 7.x-2.x. Thanks!
http://drupalcode.org/project/nodequeue.git/commit/a4ea38b
Comment #6
killes@www.drop.org commentedReopenening this, I think the update function is flawed. It seems to assume that a field always has the same ID as the taxonomy vocabulary. This is certainly not correct! In my case smartqueues ended up attached to the wrong vocab.
Comment #7
SebCorbin commentedThis problem happens when upgrading from Drupal 6, when smartqueues were handled via vocabulary ID, we need to add a hook_update_7000() that gather (or create) corresponding taxonomy reference fields and replace vids by field_ids.
Then the conversion from field_id to field_name will be handled by smartqueue_update_7001()
Comment #8
killes@www.drop.org commentedI uploaded a new patch that fixes the issue for me.
Unfortunately, I see no way to fix the issue for people who already made the upgrade.
Also, it may be required to implement some hook in case the field name changes, if it is not there already.
Comment #9
killes@www.drop.org commentedand changing the status.
Comment #10
killes@www.drop.org commentedwasn't quite right, needed hook_update_dependencies
Comment #11
killes@www.drop.org commentedIt works when I run the update stand-alone, but not in a complete update. Strange.
Comment #12
SebCorbin commentedAs said in #7, this issue now concerns only the upgrade path from D6 to D7, so you should write the update hook as hook_update_7000().
It is generally a bad practice to modify already written update hooks :)
Comment #13
killes@www.drop.org commentedWell, I didn't mess up the initial hook. If you have an idea on how to help people that already did the upgrade, let me know. I have none, since the neccessary information was deleted during the faulty upgrade.
Also, it's just a beta release...
Comment #14
fizk commented